Skip to content

regression test for #39974 - #42217

Merged
bors merged 1 commit into
rust-lang:masterfrom
venkatagiri:issue_39974
May 28, 2017
Merged

regression test for #39974#42217
bors merged 1 commit into
rust-lang:masterfrom
venkatagiri:issue_39974

Conversation

@venkatagiri

@venkatagirivenkatagiri commented May 25, 2017

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented May 25, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Mark-Simulacrum
Mark-Simulacrum reviewed May 25, 2017
View reviewed changes
Comment threadsrc/test/compile-fail/issue-39974.rs Outdated

@Mark-SimulacrumMark-SimulacrumMay 25, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to update this to something like the below:

f: [[f64; 2]; LENGTH],
//~^ ERROR mismatched types
//~| expected usize, found f64

@venkatagirivenkatagiriMay 26, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mark-Simulacrum I have updated the patch with your suggestion

@Mark-SimulacrumMark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 25, 2017
@venkatagirivenkatagiri mentioned this pull request May 25, 2017
Closed
@Mark-Simulacrum

Mark-Simulacrum commented May 26, 2017

Copy link
Copy Markdown
Member

@bors r+ (travis failure is spurious)

@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit c87f6d8 has been approved by Mark-Simulacrum

@Mark-Simulacrum

Mark-Simulacrum commented May 26, 2017

Copy link
Copy Markdown
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 26, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42217- venkatagiri:issue_39974, r=Mark-Sim…
86e4615
…ulacrum
regression test for rust-lang#39974closesrust-lang#39974
r? @Mark-Simulacrum
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 26, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42217- venkatagiri:issue_39974, r=Mark-Sim…
3567d56
…ulacrum
regression test for rust-lang#39974closesrust-lang#39974
r? @Mark-Simulacrum
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 27, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42217- venkatagiri:issue_39974, r=Mark-Sim…
ec03463
…ulacrum
regression test for rust-lang#39974closesrust-lang#39974
r? @Mark-Simulacrum
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 27, 2017
Closed
bors added a commit that referenced this pull request May 27, 2017
@bors
Auto merge of#42258- Mark-Simulacrum:rollup, r=Mark-Simulacrum
5712e03
Rollup of 10 pull requests
- Successful merges: #42103, #42137, #42162, #42167, #42175, #42207, #42217, #42246, #42249, #42251
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42217- venkatagiri:issue_39974, r=Mark-Sim…
4c74895
…ulacrum
regression test for rust-lang#39974closesrust-lang#39974
r? @Mark-Simulacrum
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 28, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42217- venkatagiri:issue_39974, r=Mark-Sim…
04a3b47
…ulacrum
regression test for rust-lang#39974closesrust-lang#39974
r? @Mark-Simulacrum
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 28, 2017
Merged
@Mark-SimulacrumMark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2017
bors added a commit that referenced this pull request May 28, 2017
@bors
Auto merge of#42276- Mark-Simulacrum:rollup, r=Mark-Simulacrum
41e74a2
Rollup of 6 pull requests
- Successful merges: #42207, #42217, #42249, #42251, #42260, #42266
- Failed merges:
@bors
bors merged commit c87f6d8 into rust-lang:masterMay 28, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rustc crashes rather than failing to compile when wrong sized type is used

4 participants

@venkatagiri@rust-highfive@Mark-Simulacrum@bors