Skip to content

Remove all instances of fragment_infos and fragment sets - #42207

Merged
bors merged 2 commits into
rust-lang:masterfrom
Nashenas88:remove_fragment_info
May 28, 2017
Merged

Remove all instances of fragment_infos and fragment sets#42207
bors merged 2 commits into
rust-lang:masterfrom
Nashenas88:remove_fragment_info

Conversation

@Nashenas88

@Nashenas88Nashenas88 commented May 24, 2017

Copy link
Copy Markdown
Contributor

Remove unused fragment structs. This was suggested by @eddyb in IRC: botbot link.

@rust-highfive

rust-highfive commented May 24, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Nashenas88

Nashenas88 commented May 24, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @eddyb

@aidanhsaidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2017
@aidanhs

aidanhs commented May 24, 2017

Copy link
Copy Markdown
Contributor

Thanks for the PR @Nashenas88! We'll keep an eye on it to make sure @eddyb or another reviewer gets to it soon.

@Nashenas88

Nashenas88 commented May 25, 2017

Copy link
Copy Markdown
ContributorAuthor

Looking into the failures now.

@Nashenas88

Nashenas88 commented May 25, 2017

Copy link
Copy Markdown
ContributorAuthor

So it seems the failing tests are just verifying the internal workings of the code that was just deleted (unless I misinterpreted them). Are there already tests for what replaced this (making these also candidates for deletion)? Or should these be modified to verify the functionality of the code that replaced fragment infos?

@eddyb

eddyb commented May 25, 2017

Copy link
Copy Markdown
Contributor

@Nashenas88 Fragments were a dead-end in dynamic drop that never got used in practice.
MIR drop elaboration is more sophisticated and has its own tests etc. You can remove the fragment ones.

@eddyb

eddyb commented May 25, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit a563f35 has been approved by eddyb

@Nashenas88

Nashenas88 commented May 26, 2017

Copy link
Copy Markdown
ContributorAuthor

@eddyb bump for merge?

@Mark-Simulacrum

Mark-Simulacrum commented May 26, 2017

Copy link
Copy Markdown
Member

You can track this PR's progress through the queue here: https://buildbot2.rust-lang.org/homu/queue/rust; you are currently 9th.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 26, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42207- Nashenas88:remove_fragment_info, r=…
f7c11a8
…eddyb
Remove all instances of fragment_infos and fragment sets
Remove unused fragment structs. This was suggested by @eddyb in IRC: [botbot link](https://botbot.me/mozilla/rustc/2017-05-23/?msg=86016574&page=2).
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 26, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 26, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42207- Nashenas88:remove_fragment_info, r=…
8ccddd9
…eddyb
Remove all instances of fragment_infos and fragment sets
Remove unused fragment structs. This was suggested by @eddyb in IRC: [botbot link](https://botbot.me/mozilla/rustc/2017-05-23/?msg=86016574&page=2).
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 26, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42207- Nashenas88:remove_fragment_info, r=…
b4f524b
…eddyb
Remove all instances of fragment_infos and fragment sets
Remove unused fragment structs. This was suggested by @eddyb in IRC: [botbot link](https://botbot.me/mozilla/rustc/2017-05-23/?msg=86016574&page=2).
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 27, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42207- Nashenas88:remove_fragment_info, r=…
20135a8
…eddyb
Remove all instances of fragment_infos and fragment sets
Remove unused fragment structs. This was suggested by @eddyb in IRC: [botbot link](https://botbot.me/mozilla/rustc/2017-05-23/?msg=86016574&page=2).
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 27, 2017
Closed
bors added a commit that referenced this pull request May 27, 2017
@bors
Auto merge of#42258- Mark-Simulacrum:rollup, r=Mark-Simulacrum
5712e03
Rollup of 10 pull requests
- Successful merges: #42103, #42137, #42162, #42167, #42175, #42207, #42217, #42246, #42249, #42251
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42207- Nashenas88:remove_fragment_info, r=…
ed80c95
…eddyb
Remove all instances of fragment_infos and fragment sets
Remove unused fragment structs. This was suggested by @eddyb in IRC: [botbot link](https://botbot.me/mozilla/rustc/2017-05-23/?msg=86016574&page=2).
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 28, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42207- Nashenas88:remove_fragment_info, r=…
f35ec61
…eddyb
Remove all instances of fragment_infos and fragment sets
Remove unused fragment structs. This was suggested by @eddyb in IRC: [botbot link](https://botbot.me/mozilla/rustc/2017-05-23/?msg=86016574&page=2).
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 28, 2017
Merged
@Mark-SimulacrumMark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2017
bors added a commit that referenced this pull request May 28, 2017
@bors
Auto merge of#42276- Mark-Simulacrum:rollup, r=Mark-Simulacrum
41e74a2
Rollup of 6 pull requests
- Successful merges: #42207, #42217, #42249, #42251, #42260, #42266
- Failed merges:
@bors
bors merged commit a563f35 into rust-lang:masterMay 28, 2017
@Nashenas88
Nashenas88 deleted the remove_fragment_info branch May 28, 2017 23:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Nashenas88@rust-highfive@aidanhs@eddyb@bors@Mark-Simulacrum@nikomatsakis