Skip to content

libcore: Implement cloned() for Option<&mut T> - #43705

Merged
bors merged 3 commits into
rust-lang:masterfrom
panicbit:option_ref_mut_cloned
Aug 30, 2017
Merged

libcore: Implement cloned() for Option<&mut T>#43705
bors merged 3 commits into
rust-lang:masterfrom
panicbit:option_ref_mut_cloned

Conversation

@panicbit

@panicbitpanicbit commented Aug 6, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@panicbit
panicbitforce-pushed the option_ref_mut_cloned branch from 8acd6e1 to 51b29d6CompareAugust 7, 2017 00:24
oli-obk
oli-obk reviewed Aug 7, 2017
View reviewed changes
Comment threadsrc/libcore/option.rs
/// # Examples
///
/// ```
/// let mut x = 12;

@oli-obkoli-obkAug 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a #![feature(option_ref_mut_cloned)] to the doc example.

@arielb1arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2017
@arielb1

arielb1 commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

r? @oli-obk I think (does this need an RFC?)

@arielb1

arielb1 commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

I guess this does need an RFC + tracking issue + stabilization track.

@oli-obk

oli-obk commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

r? @oli-obk I think

I have no bors-powers.

I guess this does need an RFC + tracking issue + stabilization track.

I don't think it needs an RFC, since we already have the implementation for Option<&T>, this is just a natural extension of that impl.

Definitely needs a tracking issue + must be unstable.

@panicbitpanicbit mentioned this pull request Aug 8, 2017
Closed
@carols10cents

carols10cents commented Aug 14, 2017

Copy link
Copy Markdown
Member

r? @aturon

@aturonaturon added the T-libs-api [DEPRECATED; DO NOT USE] label Aug 22, 2017
@aturon

aturon commented Aug 22, 2017

Copy link
Copy Markdown
Contributor

Hey, sorry for the late review!

cc @rust-lang/libs, how do y'all feel about adding this API?

@sfackler

sfackler commented Aug 23, 2017

Copy link
Copy Markdown
Member

SGTM. There aren't any other methods on Option<&T> we'd also want to copy over, right?

@dtolnay

dtolnay commented Aug 23, 2017

Copy link
Copy Markdown
Member

LGTM as well. There are no other methods.

@alexcrichton

alexcrichton commented Aug 23, 2017

Copy link
Copy Markdown
Member

👍

@carols10cents

carols10cents commented Aug 28, 2017

Copy link
Copy Markdown
Member

@aturon ping, it sounds like libs is cool with this?

@aturon

aturon commented Aug 29, 2017

Copy link
Copy Markdown
Contributor

@bors: r+

Thanks for the PR, and sorry for the delay!

@bors

bors commented Aug 29, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9618299 has been approved by aturon

arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#43705- panicbit:option_ref_mut_cloned, r=a…
f2d7045
…turon
libcore: Implement cloned() for Option<&mut T>
None
@arielb1arielb1 mentioned this pull request Aug 29, 2017
Closed
@arielb1arielb1 mentioned this pull request Aug 29, 2017
Closed
@bors

bors commented Aug 29, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9618299 with merge 3f0af79cd4c5abc9b3eb96e2a5ac4fdb2a874695...

arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#43705- panicbit:option_ref_mut_cloned, r=a…
11e75fd
…turon
libcore: Implement cloned() for Option<&mut T>
None
@arielb1arielb1 mentioned this pull request Aug 29, 2017
Merged
@arielb1

arielb1 commented Aug 29, 2017

Copy link
Copy Markdown
Contributor

@bors retry

prioritizing rollup which includes this

bors added a commit that referenced this pull request Aug 29, 2017
@bors
Auto merge of#44169- arielb1:rollup, r=arielb1
c11f689
Rollup of 12 pull requests
- Successful merges: #43705, #43778, #43918, #44076, #44117, #44121, #44126, #44134, #44135, #44141, #44144, #44158
- Failed merges:
@bors
bors merged commit 9618299 into rust-lang:masterAug 30, 2017
@panicbit
panicbit deleted the option_ref_mut_cloned branch August 30, 2017 11:25
@panicbit
panicbit restored the option_ref_mut_cloned branch August 30, 2017 23:44
@CAD97CAD97 mentioned this pull request Aug 31, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk left review comments

Assignees

@aturonaturon

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@panicbit@arielb1@oli-obk@carols10cents@aturon@sfackler@dtolnay@alexcrichton@bors