Uh oh!
There was an error while loading. Please reload this page.
bootstrap: remove unneeded extern crate - #44121
Merged
Merged
Conversation
The crate itself is internally referenced by serde_derive.
rust-highfive
commented
Aug 28, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Aug 28, 2017
Member
@bors r+ rollup |
bors
commented
Aug 28, 2017
Collaborator
📌 Commit 45d31ac has been approved by |
arielb1
commented
Aug 28, 2017
Contributor
I think we want this on 1.21 too - if #42588 makes the cut to 1.21. |
bors
commented
Aug 28, 2017
Collaborator
⌛ Testing commit 45d31ac with merge 1d8b0c548dcd8453ed077d6ba4bc251cb0188c45... |
Mark-Simulacrum
commented
Aug 28, 2017
Member
I'm marking as beta-approved. Doesn't necessarily need to be backported, but wouldn't hurt. |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crate itself is internally referenced by serde_derive.