Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Fix dependencies of build-manifest - #44144
Merged
Merged
Conversation
No need to depend on librustc! All we need is libstd Closesrust-lang#44140
rust-highfive
commented
Aug 29, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Aug 29, 2017
MemberAuthor
Mark-Simulacrum
commented
Aug 29, 2017
Member
Good point. I think the original reason this was librustc is because it depends on proc macros, but since we currently build in stage0 that's fine I believe. Worst case is it doesn't work (and I assume we test that somewhere and at least manually). @bors r+ |
bors
commented
Aug 29, 2017
Collaborator
📌 Commit ecd127d has been approved by |
frewsxcv
commented
Aug 29, 2017
Contributor
@bors rollup |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closesrust-lang#44140
alexcrichton
commented
Aug 29, 2017
MemberAuthor
We're gonna backport this to make deployments easier on beta/stable |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closesrust-lang#44140
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closesrust-lang#44140
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closesrust-lang#44140
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closesrust-lang#44140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to depend on librustc! All we need is libstd
Closes#44140