Update compiler-builtins by tamird · Pull Request #44509 · rust-lang/rust

tamird · 2017-09-11T22:51:37Z

~~I can't tell if this was ever used, but it's not used today.~~

See commits.

rust-highfive · 2017-09-11T22:51:49Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

nikomatsakis · 2017-09-11T23:29:29Z

@bors r+

bors · 2017-09-11T23:29:30Z

📌 Commit 6a2e165 has been approved by nikomatsakis

tamird · 2017-09-12T01:32:14Z

Pushed another commit - can I get another approval?

nikomatsakis · 2017-09-12T13:38:16Z

@tamird do you see the travis failures? I can't tell if they are legit or not, but they definitely seem related to the builtins code.

Also, I'm confused about the change to double quotes -- is that an unrelated change?

tamird · 2017-09-12T14:07:58Z

@nikomatsakis yeah, I think the failures have to do with compiler-builtins being updated to pick up rust-lang/compiler-builtins#188, which picked up a bunch of other stuff. I'll dig in a little deeper today or tomorrow.

The second commit is unrelated, just a drive-by as the single quotes were confusing my IDE's TOML parser (and single quotes aren't used anywhere else).

tamird · 2017-09-12T23:13:51Z

I was wrong! rustbuild is still used. I'll update this PR to just bump compiler-builtins after rust-lang/compiler-builtins#189 lands.

@nikomatsakis

Update rustbuild commentary r? @nikomatsakis This is the reason that rust-lang/rust#44509 doesn't work - the `rustbuild` feature _is_ actually used, it was just incorrectly documented here and I missed it.

@nikomatsakis

Update rustbuild commentary r? @nikomatsakis This is the reason that rust-lang/rust#44509 doesn't work - the `rustbuild` feature _is_ actually used, it was just incorrectly documented here and I missed it.

Picks up the removal of the rustbuild feature, which is still used in our local shim, along with a comment update explaining the usage.

tamird · 2017-09-14T02:57:50Z

Ready for another look!

nikomatsakis · 2017-09-14T13:36:24Z

@bors r+

bors · 2017-09-14T13:36:25Z

📌 Commit 49492cb has been approved by nikomatsakis

bors · 2017-09-14T17:22:46Z

⌛ Testing commit 49492cb with merge aad2822d25f06d7246880290520ce54723e7620e...

bors · 2017-09-14T19:36:06Z

💔 Test failed - status-travis

alexcrichton · 2017-09-14T19:38:13Z

@bors: retry

s3 outage

…nikomatsakis Update compiler-builtins ~~I can't tell if this was ever used, but it's not used today.~~ See commits.

Rollup of 17 pull requests - Successful merges: #44073, #44088, #44381, #44397, #44509, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647 - Failed merges:

rust-highfive assigned nikomatsakis Sep 11, 2017

tamird force-pushed the remove-rustbuild-feature branch from 6a2e165 to 43a0761Compare September 12, 2017 00:19

tamird changed the title ~~Remove unused rustbuild feature~~Shims cleanupSep 12, 2017

tamird force-pushed the remove-rustbuild-feature branch 2 times, most recently from 32d2e2f to 2b1fdbaCompare September 12, 2017 01:19

tamird changed the title ~~Shims cleanup~~Remove unused rustbuild featureSep 12, 2017

tamird mentioned this pull request Sep 12, 2017
Update rustbuild commentary rust-lang/compiler-builtins#189
Merged

aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 13, 2017

tamird added 2 commits September 13, 2017 22:55

Use double quotes to appease some TOML parsers
313b8f8

Update compiler-builtins
49492cb
Picks up the removal of the rustbuild feature, which is still used in our local shim, along with a comment update explaining the usage.

tamird force-pushed the remove-rustbuild-feature branch from 2b1fdba to 49492cbCompare September 14, 2017 02:56

tamird changed the title ~~Remove unused rustbuild feature~~Update compiler-builtinsSep 14, 2017

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
Rollup merge ofrust-lang#44509- tamird:remove-rustbuild-feature, r=…
334da4a
…nikomatsakis Update compiler-builtins ~~I can't tell if this was ever used, but it's not used today.~~ See commits.

TimNN mentioned this pull request Sep 17, 2017
Rollup of 19 pull requests #44649
Closed

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
Rollup merge ofrust-lang#44509- tamird:remove-rustbuild-feature, r=…
6a3dbaa
…nikomatsakis Update compiler-builtins ~~I can't tell if this was ever used, but it's not used today.~~ See commits.

TimNN mentioned this pull request Sep 17, 2017
Rollup of 18 pull requests #44652
Closed

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
Rollup merge ofrust-lang#44509- tamird:remove-rustbuild-feature, r=…
39710f8
…nikomatsakis Update compiler-builtins ~~I can't tell if this was ever used, but it's not used today.~~ See commits.

TimNN mentioned this pull request Sep 17, 2017
Rollup of 17 pull requests #44654
Merged

bors merged commit 49492cb into rust-lang:masterSep 17, 2017

tamird deleted the remove-rustbuild-feature branch September 17, 2017 16:43

Uh oh!

Uh oh!

Conversation

tamird commented Sep 11, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Sep 11, 2017

Uh oh!

nikomatsakis commented Sep 11, 2017

Uh oh!

bors commented Sep 11, 2017

Uh oh!

tamird commented Sep 12, 2017

Uh oh!

nikomatsakis commented Sep 12, 2017

Uh oh!

tamird commented Sep 12, 2017

Uh oh!

tamird commented Sep 12, 2017

Uh oh!

tamird commented Sep 14, 2017

Uh oh!

nikomatsakis commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

alexcrichton commented Sep 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tamird commented Sep 11, 2017•
edited
Loading