Uh oh!
There was an error while loading. Please reload this page.
Rollup of 19 pull requests - #44649
Closed
TimNN wants to merge 59 commits into
Closed
Conversation
…r during expansion)
Picks up the removal of the rustbuild feature, which is still used in our local shim, along with a comment update explaining the usage.
Removing unwanted file merged in a previous commit
The extra alloca was only necessary because it made LLVM implicitly handle the necessary deref to get to the actual value. The same happens for indirect arguments that have the byval attribute. But the Rust ABI does not use the byval attribute and so we need to manually add the deref operation to the debuginfo.
Just a routine update
* Add `T: ?Sized` bound to {`Arc`,`Rc`}::{`from_raw`,`into_raw`}net::tcp::tests::connect_timeout_unroutable fails when the network is unreachable, like on a laptop disconnected from wifi. Check for this error and allow the test to pass. Closesrust-lang#44645
…crichton
Implement `Arc`/`Rc` raw pointer conversions for `?Sized`
* Add `T: ?Sized` bound to {`Arc`,`Rc`}::{`from_raw`,`into_raw`}…ried Fix "new trace_macros doesn't work if there's an error during expansion" Fixesrust-lang#43493
ci: introduce haiku x86_64 builder
…uietMisdreavus Codeblock color <img width="1440" alt="screen shot 2017-09-07 at 21 53 58" src="https://user-images.githubusercontent.com/3050060/30183045-4319108e-9419-11e7-98da-da54952cab37.png"> This screenshot has been generated from: ```rust /// foo /// /// ```compile_fail /// foo(); /// ``` /// /// ```ignore /// goo(); /// ``` /// /// ``` /// let x = 0; /// ``` pub fn bar() -> usize { 2 } ``` r? @QuietMisdreavus cc @rust-lang/docs
…nikomatsakis Update compiler-builtins ~~I can't tell if this was ever used, but it's not used today.~~ See commits.
{compiler-builtins,libc} shim cleanup
~~Depends on rust-lang/libc#764; opening early for feedback.~~ r? @alexcrichtonextend E0623 for earlybound and latebound for structs This fixesrust-lang#44508 r? @nikomatsakis
…-szero-optimization, r=arielb1 remove overzealous Box<ZeroSizeType> optimization
rustdoc: pretty-print Unevaluated expressions in types. Fixesrust-lang#44555. r? @nikomatsakis
… r=alexcrichton stabilized iterator_for_each (closesrust-lang#42986) Also updated clippy and rls as these use the iterator_for_each I've made my first PR's today so most likely I've done something wrong. Sorry about that!
Avoid unnecessary allocas for indirect function arguments The extra alloca was only necessary because it made LLVM implicitly handle the necessary deref to get to the actual value. The same happens for indirect arguments that have the byval attribute. But the Rust ABI does not use the byval attribute and so we need to manually add the deref operation to the debuginfo.
…=alexcrichton stabilized compiler_fences (fixesrust-lang#41091) I did not know what to proceed with "unstable-book" entry. The feature would no longer be unstable so I have deleted it. If it was the wrong call I'll revert it (unfortunately his case is not described in the CONTRIBUTING.md).
…imulacrum Update cargo submodule Just a routine update
…1, r=aidanhs ci: Upload/download from a new S3 bucket Moving buckets from us-east-1 to us-west-1 because us-west-1 is where rust-central-station itself runs and in general is where we have all our other buckets.
…uietMisdreavus Fix incorrect `into_inner` link in docs. Fixesrust-lang#42373.
…crum compiletest: print the correct basename of the src dir See <Manishearth/compiletest-rs#76>. Fixesrust-lang#40712
stabilized needs_drop (fixesrust-lang#41890) fixesrust-lang#41890
Ensure tcp test case passes when disconnected from network net::tcp::tests::connect_timeout_unroutable fails when the network is unreachable, like on a laptop disconnected from wifi. Check for this error and allow the test to pass. Closesrust-lang#44645
TimNN
commented
Sep 17, 2017
ContributorAuthor
@bors r+ p=1 |
bors
commented
Sep 17, 2017
Collaborator
📌 Commit 7e08a23 has been approved by |
bors
commented
Sep 17, 2017
Collaborator
⌛ Testing commit 7e08a23 with merge d8e81f8a7154a4106ff559124d1a9ae408b288c3... |
bors
commented
Sep 17, 2017
Collaborator
💔 Test failed - status-travis |
TimNN
commented
Sep 17, 2017
ContributorAuthor
Failure: I'm gonna guess and say this is likely #44573, so let's try again without it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arc/Rcraw pointer conversions for?Sized#44073, Fix "new trace_macros doesn't work if there's an error during expansion" #44088, ci: introduce haiku x86_64 builder #44381, Codeblock color #44397, Update compiler-builtins #44509, {compiler-builtins,libc} shim cleanup #44515, Add Rustfmt #44533, extend E0623 for earlybound and latebound for structs #44549, remove overzealous Box<ZeroSizeType> optimization #44553, rustdoc: pretty-print Unevaluated expressions in types. #44562, stabilized iterator_for_each (closes #42986) #44567, Avoid unnecessary allocas for indirect function arguments #44573, stabilized compiler_fences (fixes #41091) #44595, Update cargo submodule #44604, ci: Upload/download from a new S3 bucket #44617, Fix incorrectinto_innerlink in docs. #44622, compiletest: print the correct basename of the src dir #44630, stabilized needs_drop (fixes #41890) #44639, Ensure tcp test case passes when disconnected from network #44647