Uh oh!
There was an error while loading. Please reload this page.
compiletest: print the correct basename of the src dir - #44630
Merged
Conversation
rust-highfive
commented
Sep 16, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
commented
Sep 16, 2017
Member
Does this close #40712? |
laumann
reviewed
Sep 16, 2017
There was a problem hiding this comment.
config.src_base is already a PathBuf so wouldn't it suffice to just write config.src_base?
MemberAuthor
There was a problem hiding this comment.
That will print the absolute path to the test. I wanted to make it relative to the current working directory, and this is the crude approximation I ended up with.
RalfJung
commented
Sep 16, 2017
MemberAuthor
@kennytm Yes I think it does. |
Mark-Simulacrum
commented
Sep 16, 2017
Member
@bors r+ |
bors
commented
Sep 16, 2017
Collaborator
📌 Commit 83589f2 has been approved by |
TimNN added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
…crum compiletest: print the correct basename of the src dir See <Manishearth/compiletest-rs#76>. Fixesrust-lang#40712
TimNN added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
…crum compiletest: print the correct basename of the src dir See <Manishearth/compiletest-rs#76>. Fixesrust-lang#40712
TimNN added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
…crum compiletest: print the correct basename of the src dir See <Manishearth/compiletest-rs#76>. Fixesrust-lang#40712
bors added a commit
that referenced
this pull request
Sep 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Manishearth/compiletest-rs#76.
Fixes#40712