Uh oh!
There was an error while loading. Please reload this page.
Fix example in transmute; add safety requirement to Vec::from_raw_parts - #44536
Merged
Conversation
rust-highfive
commented
Sep 13, 2017
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
strega-nil
approved these changes
Sep 13, 2017
strega-nil
left a comment
Contributor
There was a problem hiding this comment.
looks good to me 👍
thanks @Havvy
kennytm
reviewed
Sep 13, 2017
Member
There was a problem hiding this comment.
You mean as *mut Option<&i32> here?
[01:05:15] ---- intrinsics.rs - intrinsics::transmute (line 837) stdout ----
[01:05:15] error[E0412]: cannot find type `T` in this scope
[01:05:15] --> intrinsics.rs:29:61
[01:05:15] |
[01:05:15] 29 | Vec::from_raw_parts(v_orig.as_mut_ptr() as *mut Option<&T>,
[01:05:15] | ^ not found in this scope
steveklabnik
commented
Sep 13, 2017
Contributor
@bors: r+ rollup thanks! |
bors
commented
Sep 13, 2017
Collaborator
📌 Commit 9dd2ee1 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 13, 2017
Fix example in transmute; add safety requirement to Vec::from_raw_parts This fixes the second bullet point on rust-lang#44281 and also removes some incorrect information.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 14, 2017
Fix example in transmute; add safety requirement to Vec::from_raw_parts This fixes the second bullet point on rust-lang#44281 and also removes some incorrect information.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 15, 2017
Fix example in transmute; add safety requirement to Vec::from_raw_parts This fixes the second bullet point on rust-lang#44281 and also removes some incorrect information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the second bullet point on #44281 and also removes some incorrect information.