Uh oh!
There was an error while loading. Please reload this page.
Rollup of 18 pull requests - #44550
Closed
GuillaumeGomez wants to merge 44 commits into
Closed
Conversation
OpenSSL's Configure script is missing a shebang. On some platforms, execve falls back to execution with the shell. Some other platforms, like musl, will fail with an exec format error. Avoid this by calling perl explicitly (since it's a perl script).
This handles the case for `CrateTypeExecutable` and `+crt_static`. I reworked the match block to avoid duplicating the `attempt_static` and error checking code again (this case would have been a copy of the `CrateTypeCdylib`/`CrateTypeStaticlib` case). On `linux-musl` targets where `std` was built with `crt_static = false` in `config.toml`, this change brings the test suite from entirely failing to mostly passing. This change should not affect behavior for other crate types, or for targets which do not respect `+crt_static`.
So that you can scroll down the list of labels along with these explanations.
Explicitly run perl for OpenSSL Configure OpenSSL's Configure script is missing a shebang. On some platforms, execve falls back to execution with the shell. Some other platforms, like musl, will fail with an exec format error. Avoid this by calling perl explicitly (since it's a perl script).
…=QuietMisdreavus Fix rendering of const keyword for functions Fixesrust-lang#44187. r? @QuietMisdreavus
Require rlibs for dependent crates when linking static executables This handles the case for `CrateTypeExecutable` and `+crt_static`. I reworked the match block to avoid duplicating the `attempt_static` and error checking code again (this case would have been a copy of the `CrateTypeCdylib`/`CrateTypeStaticlib` case). On `linux-musl` targets where `std` was built with `crt_static = false` in `config.toml`, this change brings the test suite from entirely failing to mostly passing. This change should not affect behavior for other crate types, or for targets which do not respect `+crt_static`.
…crichton Attempt to fix the component manifest problem for rls-preview cc rust-lang#44270 See rust-lang#44270
…etMisdreavus rustdoc: Don't counts ids twice when using --enable-commonmark cc @GuillaumeGomez r? @QuietMisdreavus
Implement named threads on Windows (v2) https://msdn.microsoft.com/en-us/library/windows/desktop/mt774976(v=vs.85).aspx Windows 10 version 1607 finally added a sensible API for naming threads, so we can now implement named threads without having to use MSVC compiler extensions like before. VS2017s debugger and the WPA profiler already use this API where available, but other tools may need some time to catch up. 
…=frewsxcv Clarify the behavior of UDP sockets wrt. multiple addresses in `connect` CC @frewsxcvrust-lang#22569rust-lang#44209
…richton update mdbook This eliminates some warnings r? @alexcrichton
Add `impl From<Vec<Span>> for MultiSpan`. A simple `impl`. r? @nrc
…ewsxcv Add doc example to String::as_mut_str Fixesrust-lang#44429.
Add short doc examples for str::from_utf8_mut Fixesrust-lang#44462
…on, r=Mark-Simulacrum Update label explanations Some of the newer labels weren't covered in CONTRIBUTING.md :) r? @Mark-Simulacrum
Add doc examples to str::from_utf8_unchecked_mut Fixesrust-lang#44461
Added an example for `std::str::into_boxed_bytes()` This solves issue rust-lang#44423.
Add doc example to str::from_boxed_utf8_unchecked Fixesrust-lang#44463.
Add an example of std::str::encode_utf16 Closesrust-lang#44419
Fix example in transmute; add safety requirement to Vec::from_raw_parts This fixes the second bullet point on rust-lang#44281 and also removes some incorrect information.
…QuietMisdreavus Openoptions docs r? @QuietMisdreavus
rust-highfive
commented
Sep 13, 2017
Contributor
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Sep 13, 2017
MemberAuthor
@bors: r+ p=1 |
bors
commented
Sep 13, 2017
Collaborator
📌 Commit cfd19f4 has been approved by |
arielb1
commented
Sep 13, 2017
Contributor
@bors p=10 |
bors
commented
Sep 13, 2017
Collaborator
⌛ Testing commit cfd19f4 with merge 767d21950aa88333be4f47d3bc25d503c32e049b... |
bors
commented
Sep 13, 2017
Collaborator
💔 Test failed - status-travis |
aidanhs
commented
Sep 13, 2017
Contributor
Failure possibly caused by #44279 (best guess) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect#44388, update mdbook #44430, Addimpl From<Vec<Span>> for MultiSpan. #44450, Add doc example to String::as_mut_str #44453, Add short doc examples for str::from_utf8_mut #44472, Update label explanations #44476, Add doc examples to str::from_utf8_unchecked_mut #44477, Added an example forstd::str::into_boxed_bytes()#44485, Add doc example to str::from_boxed_utf8_unchecked #44497, Add an example of std::str::encode_utf16 #44521, Fix example in transmute; add safety requirement to Vec::from_raw_parts #44536, Openoptions docs #44541