Skip to content

stabilize tcpstream_connect_timeout (closes #43079) - #44563

Merged
bors merged 1 commit into
rust-lang:masterfrom
budziq:stablilize_tcpstream_connect_timeout
Sep 15, 2017
Merged

stabilize tcpstream_connect_timeout (closes #43079)#44563
bors merged 1 commit into
rust-lang:masterfrom
budziq:stablilize_tcpstream_connect_timeout

Conversation

@budziq

@budziqbudziq commented Sep 14, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Sep 14, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@budziq
budziqforce-pushed the stablilize_tcpstream_connect_timeout branch from 92bd686 to 199cb82CompareSeptember 14, 2017 14:19
@alexcrichton

alexcrichton commented Sep 14, 2017

Copy link
Copy Markdown
Member

@bors: r+ rollup

Thanks @budziq!

@bors

bors commented Sep 14, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 199cb82 has been approved by alexcrichton

@alexcrichtonalexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 14, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017
@frewsxcv
Rollup merge ofrust-lang#44563- budziq:stablilize_tcpstream_connect…
4af8acd
…_timeout, r=alexcrichton
stabilize tcpstream_connect_timeout (closesrust-lang#43079)
@frewsxcvfrewsxcv mentioned this pull request Sep 15, 2017
Merged
bors added a commit that referenced this pull request Sep 15, 2017
@bors
Auto merge of#44585- frewsxcv:rollup, r=frewsxcv
d86a7f7
Rollup of 23 pull requests
- Successful merges: #44131, #44254, #44368, #44374, #44378, #44388, #44430, #44450, #44453, #44472, #44476, #44477, #44485, #44497, #44521, #44534, #44536, #44541, #44552, #44559, #44563, #44569, #44572
- Failed merges:
@bors
bors merged commit 199cb82 into rust-lang:masterSep 15, 2017
@alexcrichtonalexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 15, 2017
@budziq
budziq deleted the stablilize_tcpstream_connect_timeout branch September 17, 2017 07:03
@dtolnaydtolnay mentioned this pull request Sep 21, 2017
Merged
@dtolnaydtolnay added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2017
dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017
@dtolnay
Backport libs stabilizations to 1.21 beta
874124b
This includes the following stabilizations:
- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
This was referenced Sep 25, 2017
Merged
Closed
dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 26, 2017
@dtolnay
Backport libs stabilizations to 1.21 beta
a8117df
This includes the following stabilizations:
- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
bors added a commit that referenced this pull request Sep 26, 2017
@bors
Auto merge of#44823- dtolnay:backport21, r=alexcrichton
3c3cd3f
[beta] Backport accepted PRs to 1.21
Backport of:
- ~don't suggest placing `use` statements into expanded code #44215
- stabilize tcpstream_connect_timeout #44563
- stabilized iterator_for_each #44567
- travis: Move sccache to the us-west-1 region #44574
- stabilized ord_max_min #44593
- stabilized compiler_fences #44595
- ci: Upload/download from a new S3 bucket #44617
- stabilized needs_drop #44639
- Stabilized vec_splice and modified splice tracking issue #44640
- Backport libs stabilizations to 1.21 beta #44824
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#44824- dtolnay:22really21, r=alexcrichton
570f1ce
Backport libs stabilizations to 1.21 beta
Includes the following stabilizations:
- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
These have been backported in rust-lang#44823.
@dtolnaydtolnay mentioned this pull request Oct 10, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BurntSushiBurntSushi

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.relnotesMarks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@budziq@rust-highfive@alexcrichton@bors@BurntSushi@dtolnay