Skip to content

Backport libs stabilizations to 1.21 beta - #44824

Closed
dtolnay wants to merge 1 commit into
rust-lang:masterfrom
dtolnay:22really21
Closed

Backport libs stabilizations to 1.21 beta#44824
dtolnay wants to merge 1 commit into
rust-lang:masterfrom
dtolnay:22really21

Conversation

@dtolnay

Copy link
Copy Markdown
Member

This includes the following stabilizations:
- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
@dtolnaydtolnay added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 25, 2017
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Sep 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 874124b has been approved by alexcrichton

@alexcrichtonalexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 25, 2017
@alexcrichton

Copy link
Copy Markdown
Member

@bors: rollup

@carols10centscarols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 25, 2017
bors added a commit that referenced this pull request Sep 26, 2017
[beta] Backport accepted PRs to 1.21
Backport of:
- ~don't suggest placing `use` statements into expanded code #44215
- stabilize tcpstream_connect_timeout #44563
- stabilized iterator_for_each #44567
- travis: Move sccache to the us-west-1 region #44574
- stabilized ord_max_min #44593
- stabilized compiler_fences #44595
- ci: Upload/download from a new S3 bucket #44617
- stabilized needs_drop #44639
- Stabilized vec_splice and modified splice tracking issue #44640
- Backport libs stabilizations to 1.21 beta #44824
@dtolnaydtolnay removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 26, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
Backport libs stabilizations to 1.21 beta
Includes the following stabilizations:
- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
These have been backported in rust-lang#44823.
bors added a commit that referenced this pull request Sep 30, 2017
@bors

bors commented Sep 30, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #44936) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

Merged in #44936.

@dtolnay
dtolnay deleted the 22really21 branch October 1, 2017 15:56
@dtolnaydtolnay added T-release Relevant to the release subteam, which will review and decide on the PR/issue. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@dtolnay@rust-highfive@alexcrichton@bors@Mark-Simulacrum@carols10cents