Uh oh!
There was an error while loading. Please reload this page.
Fix title heading overlap in rust doc - #45450
Conversation
GuillaumeGomez
commented
Oct 22, 2017
killercup
commented
Oct 22, 2017
Hm, this is not how I would would fix. Why give this header a margin-left, when all other headers with collapse buttons next to them don't have one? It makes the layout look quite unbalanced to me. In addition, it still has weird spacing on hover as the collapse button and the section link marker overlap: I'd suggest getting rid of the "§" pseudo-element for the first header ( |
GuillaumeGomez
commented
Oct 23, 2017
I thought at first about removing all "§" but it seemed inconsistent with the rest. Therefore, I came up with this solution which still seems the best for me. I don't feel like the rendering is unbalanced, and this is something we quite often around. However, if a majority of people thinks the same as you, I'll just update this way but I really don't like this idea. |
steveklabnik
commented
Oct 27, 2017
I told @GuillaumeGomez I'd check this out, but I am terrible at CSS, so I don't have any strong opinions here. |
GuillaumeGomez
commented
Oct 27, 2017
Well, talk about the design then. Does it seem good for you from this perspective? |
QuietMisdreavus
commented
Oct 31, 2017
Plain: Hover: This is Chrome on Windows. Unless there's something else going on in other browsers on other platforms, this looks Good Enough for me. Farther tiny CSS PRs are easy to review. @bors r+ rollup |
bors
commented
Oct 31, 2017
📌 Commit 237ad82 has been approved by |
…tMisdreavus Fix title heading overlap in rust doc Fixesrust-lang#45158. To be noted that this margin only appears when a title is the first element. <img width="1440" alt="screen shot 2017-10-22 at 16 08 44" src="https://user-images.githubusercontent.com/3050060/31862746-6411070e-b743-11e7-9a75-4159e1f7f1d6.png"> r? @rust-lang/docs




Fixes#45158.
To be noted that this margin only appears when a title is the first element.
r? @rust-lang/docs