Skip to content

Tidy: track rustc_const_unstable feature gates as well - #45671

Merged
bors merged 2 commits into
rust-lang:masterfrom
est31:master
Nov 1, 2017
Merged

Tidy: track rustc_const_unstable feature gates as well#45671
bors merged 2 commits into
rust-lang:masterfrom
est31:master

Conversation

@est31

@est31est31 commented Oct 31, 2017

Copy link
Copy Markdown
Member

This is important for the unstable book stub generation.

@est31
Tidy: track rustc_const_unstable feature gates as well
911e476
This is important for the unstable book stub generation.
@rust-highfive

rust-highfive commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@est31

est31 commented Oct 31, 2017

Copy link
Copy Markdown
MemberAuthor

cc @steveklabnik@QuietMisdreavus

@steveklabnik

steveklabnik commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

This (hopefully) addresses #44644

@QuietMisdreavus

QuietMisdreavus commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

Will this grab the AtomicInteger types? Those put their feature gates as macro input, not a full attribute: https://github.com/rust-lang/rust/pull/43017/files#diff-9aa1eb154ee636dcdcbcb58bc4c6f6c1R1338

@est31
Also support macro generated atomic types
6a16a7c
This is kind of a hack but it works...
@est31

est31 commented Oct 31, 2017

Copy link
Copy Markdown
MemberAuthor

@QuietMisdreavus good point, they should be added now.

@alexcrichton

alexcrichton commented Nov 1, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Nov 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 6a16a7c has been approved by alexcrichton

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 1, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 1, 2017
@kennytm
Rollup merge ofrust-lang#45671- est31:master, r=alexcrichton
0284550
Tidy: track rustc_const_unstable feature gates as well
This is important for the unstable book stub generation.
@kennytmkennytm mentioned this pull request Nov 1, 2017
Merged
bors added a commit that referenced this pull request Nov 1, 2017
@bors
Auto merge of#45674- kennytm:rollup, r=kennytm
7402866
Rollup of 14 pull requests
- Successful merges: #45450, #45579, #45602, #45619, #45624, #45644, #45646, #45648, #45649, #45650, #45652, #45660, #45664, #45671
- Failed merges:
@bors
bors merged commit 6a16a7c into rust-lang:masterNov 1, 2017
@steveklabniksteveklabnik mentioned this pull request Jan 8, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@est31@rust-highfive@steveklabnik@QuietMisdreavus@alexcrichton@bors@kennytm@aturon