Skip to content

Count type aliases used in patterns as usage by dead_code lint - #45646

Merged
bors merged 1 commit into
rust-lang:masterfrom
sinkuu:dead-code-alias-in-pat
Nov 1, 2017
Merged

Count type aliases used in patterns as usage by dead_code lint#45646
bors merged 1 commit into
rust-lang:masterfrom
sinkuu:dead-code-alias-in-pat

Conversation

@sinkuu

@sinkuusinkuu commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

Fixes#45614.

@rust-highfive

rust-highfive commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sinkuusinkuu changed the title Count type aliases used in patterns by dead_code lintCount type aliases used in patterns as usage by dead_code lintOct 31, 2017
@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2017
@arielb1

arielb1 commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 31, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit b67d72b has been approved by arielb1

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 1, 2017
@kennytm
Rollup merge ofrust-lang#45646- sinkuu:dead-code-alias-in-pat, r=ar…
cf0fe06
…ielb1
Count type aliases used in patterns as usage by dead_code lint
Fixesrust-lang#45614.
@kennytmkennytm mentioned this pull request Nov 1, 2017
Merged
bors added a commit that referenced this pull request Nov 1, 2017
@bors
Auto merge of#45674- kennytm:rollup, r=kennytm
7402866
Rollup of 14 pull requests
- Successful merges: #45450, #45579, #45602, #45619, #45624, #45644, #45646, #45648, #45649, #45650, #45652, #45660, #45664, #45671
- Failed merges:
@bors
bors merged commit b67d72b into rust-lang:masterNov 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sinkuu@rust-highfive@arielb1@bors@eddyb@kennytm