Skip to content

Replace libtest/lib.rs:FnBox with std::boxed::FnBox. - #46636

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcv-fn-box
Dec 22, 2017
Merged

Replace libtest/lib.rs:FnBox with std::boxed::FnBox.#46636
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcv-fn-box

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Dec 10, 2017

Copy link
Copy Markdown
Contributor

Fixes#41810.

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2017
@frewsxcv
frewsxcvforce-pushed the frewsxcv-fn-box branch 4 times, most recently from 7e601ee to cbd2710CompareDecember 11, 2017 02:56
kennytm
kennytm reviewed Dec 14, 2017
View reviewed changes
Comment threadsrc/libtest/lib.rs Outdated

@kennytmkennytmDec 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can simply be Box::new(f) I think.

@frewsxcvfrewsxcvDec 15, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in the latest force push

@frewsxcvfrewsxcv added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 17, 2017
@frewsxcv

frewsxcv commented Dec 21, 2017

Copy link
Copy Markdown
ContributorAuthor

assigning to someone random from the compiler team (unless there's a better team to review this)

r? @estebank

@estebank

estebank commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 21, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4f04f97 has been approved by estebank

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 21, 2017
@kennytm
Rollup merge ofrust-lang#46636- frewsxcv:frewsxcv-fn-box, r=estebank
71c6d23
Replace libtest/lib.rs:FnBox with std::boxed::FnBox.
Fixesrust-lang#41810.
@kennytmkennytm mentioned this pull request Dec 21, 2017
Merged
bors added a commit that referenced this pull request Dec 21, 2017
@bors
Auto merge of#46922- kennytm:rollup, r=kennytm
ba27415
Rollup of 14 pull requests
- Successful merges: #46636, #46780, #46784, #46809, #46814, #46820, #46839, #46847, #46858, #46878, #46884, #46890, #46898, #46918
- Failed merges:
@bors
bors merged commit 4f04f97 into rust-lang:masterDec 22, 2017
@dwrenshadwrensha mentioned this pull request Dec 23, 2017
Merged
@pitdickerpitdicker mentioned this pull request Jan 4, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytmkennytmkennytm left review comments

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frewsxcv@estebank@bors@kennytm