Uh oh!
There was an error while loading. Please reload this page.
tweaks and fixes for doc(include) - #46858
Conversation
rust-highfive
commented
Dec 19, 2017
(rust_highfive has picked a reviewer for you, use r? to override) |
jonhoo
commented
Dec 20, 2017
Hmm, I wonder if the |
SimonSapin
commented
Dec 20, 2017
@jonhoo What happens with |
QuietMisdreavus
commented
Dec 20, 2017
Right now, empty doc comments and doc attributes will satisfy the |
SimonSapin
commented
Dec 20, 2017
I think that an empty included doc file should be consistent with empty doc-comments. If we want to change what that does, maybe discuss it in a separate issue or PR. |
estebank
commented
Dec 20, 2017
@bors r+ |
bors
commented
Dec 20, 2017
📌 Commit cbbb73b has been approved by |
frewsxcv
commented
Dec 21, 2017
@bors rollup |
… r=estebank tweaks and fixes for doc(include) This PR makes a handful of changes around `#[doc(include="file.md")]` (rust-lang#44732): * Turns errors when loading files into full errors. This matches the original RFC text. * Makes the `missing_docs` lint check for `#[doc(include="file.md")]` as well as regular `#[doc="text"]` attributes. * Loads files included by `#[doc(include="file.md")]` into dep-info, mirroring the behavior of `include_str!()` and friends. * Adds or modifies tests to check for all of these.
This PR makes a handful of changes around
#[doc(include="file.md")](#44732):missing_docslint check for#[doc(include="file.md")]as well as regular#[doc="text"]attributes.#[doc(include="file.md")]into dep-info, mirroring the behavior ofinclude_str!()and friends.