Cleanup for libgraphviz by bjorn3 · Pull Request #46784 · rust-lang/rust

bjorn3 · 2017-12-17T12:05:08Z

No description provided.

rust-highfive · 2017-12-17T12:05:19Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

oli-obk · 2017-12-17T14:18:43Z

Missing ?

oli-obk · 2017-12-17T14:19:06Z

Missing ?

oli-obk · 2017-12-17T14:19:39Z

Are cursors necessary? Can't you write to vecs directly?

Didn't know you could write to them without cursor.

bjorn3 · 2017-12-17T18:09:56Z

As it can't fail. (Its on the Vec, not the W)

oli-obk · 2017-12-17T21:35:14Z

This change removes a newline, which breaks some tests

oli-obk

lgtm now. Can you just squash the commits into one?

bjorn3 · 2017-12-18T13:00:34Z

Rebased

pnkfelix · 2017-12-21T12:24:53Z

+ writeln!(w, "digraph {} {{", g.graph_id().as_slice())?;
 for n in g.nodes().iter() {
-indent(w)?;
+write!(w, " ")?;


(personally I usually prefer a function like indent over having to double-check that the string contents all match up, but since there are only two calls to indent I'm not going to make a fuss)

pnkfelix · 2017-12-21T12:27:16Z

@bors r+ rollup

bors · 2017-12-21T12:27:16Z

📌 Commit 2e2defd has been approved by pnkfelix

Cleanup for libgraphviz

Rollup of 14 pull requests - Successful merges: #46636, #46780, #46784, #46809, #46814, #46820, #46839, #46847, #46858, #46878, #46884, #46890, #46898, #46918 - Failed merges:

rust-highfive assigned pnkfelix Dec 17, 2017

oli-obk requested changes Dec 17, 2017
View reviewed changes

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2017

oli-obk reviewed Dec 17, 2017
View reviewed changes

oli-obk approved these changes Dec 18, 2017
View reviewed changes

Cleanup for libgraphviz
2e2defd

bjorn3 force-pushed the patch-1 branch from 31d625b to 2e2defdCompare December 18, 2017 13:00

pnkfelix reviewed Dec 21, 2017
View reviewed changes

pnkfelix added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2017

kennytm added a commit to kennytm/rust that referenced this pull request Dec 21, 2017
Rollup merge ofrust-lang#46784- bjorn3:patch-1, r=pnkfelix
9341321
Cleanup for libgraphviz

kennytm mentioned this pull request Dec 21, 2017
Rollup of 14 pull requests #46922
Merged

bors merged commit 2e2defd into rust-lang:masterDec 22, 2017

bjorn3 deleted the patch-1 branch December 22, 2017 07:26

Uh oh!

Uh oh!

Conversation

bjorn3 commented Dec 17, 2017

Uh oh!

rust-highfive commented Dec 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjorn3 commented Dec 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

bjorn3 commented Dec 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pnkfelix commented Dec 21, 2017

Uh oh!

bors commented Dec 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants