Uh oh!
There was an error while loading. Please reload this page.
add documentation from doc(include) to analysis data - #47496
Conversation
rust-highfive
commented
Jan 16, 2018
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
estebank
commented
Jan 16, 2018
Should this have some kind of test? I don't know how to test it though. r=me once ci finishes. |
QuietMisdreavus
commented
Jan 16, 2018
Before pushing, i had a quick look through the tests in |
estebank
commented
Jan 16, 2018
I figured that might be the case :-/ @nrc are you aware of any testing for save-analysis? |
nrc
commented
Jan 18, 2018
There are a couple of smoke tests in run-make/save-analysis or something similar which basically only test that the compiler doesn't crash. However, it is useful to add things like this to one of those tests. |
shepmaster
commented
Jan 26, 2018
Ping from triage @QuietMisdreavus ! We haven't heard from you in a week; will you be able to address the recent comments soon? |
QuietMisdreavus
commented
Jan 30, 2018
Whoops, forgot about this one. I guess the way forward would be to just add something with |
emilyalbini
commented
Feb 5, 2018
@estebank ping from triage! |
estebank
commented
Feb 5, 2018
@bors r+ rollup |
bors
commented
Feb 5, 2018
📌 Commit 5a350c1 has been approved by |
…estebank add documentation from doc(include) to analysis data cc rust-lang#44732 Currently save-analysis only loads docs from plain doc comments and doc attributes. Since `#[doc(include="filename.md")]` doesn't create a plain doc attribute when it loads the file, we need to be sure to pick up this info for the analysis data.
cc #44732
Currently save-analysis only loads docs from plain doc comments and doc attributes. Since
#[doc(include="filename.md")]doesn't create a plain doc attribute when it loads the file, we need to be sure to pick up this info for the analysis data.