Skip to content

Stabilize use_nested_groups - #47948

Merged
bors merged 1 commit into
rust-lang:masterfrom
emilyalbini:use-nested-groups-stabilize
Feb 6, 2018
Merged

Stabilize use_nested_groups#47948
bors merged 1 commit into
rust-lang:masterfrom
emilyalbini:use-nested-groups-stabilize

Conversation

@emilyalbini

@emilyalbiniemilyalbini commented Feb 1, 2018

Copy link
Copy Markdown
Member

As requested in #44494. Documentation PRs already sent.

@rust-highfive

rust-highfive commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

petrochenkov commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 1, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e532265 has been approved by petrochenkov

@petrochenkovpetrochenkov added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 1, 2018
@kennytmkennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 2, 2018
@Mark-Simulacrum

Mark-Simulacrum commented Feb 2, 2018

Copy link
Copy Markdown
Member

@bors rollup

This was referenced Feb 3, 2018
Closed
Closed
@kennytmkennytm mentioned this pull request Feb 4, 2018
Merged
@bors

bors commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #47998) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov

petrochenkov commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

Needs rebase.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2018
@emilyalbini
emilyalbiniforce-pushed the use-nested-groups-stabilize branch from e532265 to 01f0814CompareFebruary 5, 2018 09:23
@emilyalbini

emilyalbini commented Feb 5, 2018

Copy link
Copy Markdown
MemberAuthor

Rebased.

@emilyalbiniemilyalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2018
@petrochenkov

petrochenkov commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 01f0814 has been approved by petrochenkov

@petrochenkovpetrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2018
@petrochenkov

petrochenkov commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

@bors delegate+

@bors

bors commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

✌️ @pietroalbini can now approve this pull request

kennytm added a commit to kennytm/rust that referenced this pull request Feb 5, 2018
@kennytm
Rollup merge ofrust-lang#47948- pietroalbini:use-nested-groups-stab…
55aef3c
…ilize, r=petrochenkov
Stabilize use_nested_groups
As requested in rust-lang#44494. Documentation PRs already sent.
@kennytmkennytm mentioned this pull request Feb 5, 2018
Merged
bors added a commit that referenced this pull request Feb 6, 2018
@bors
Auto merge of#48017- kennytm:rollup, r=kennytm
b224fc8
Rollup of 10 pull requests
- Successful merges: #46030, #47496, #47543, #47704, #47753, #47807, #47948, #47959, #48003, #48007
- Failed merges:
@bors
bors merged commit 01f0814 into rust-lang:masterFeb 6, 2018
@stanislav-tkachstanislav-tkach mentioned this pull request Mar 30, 2018
Merged
@emilyalbini
emilyalbini deleted the use-nested-groups-stabilize branch May 13, 2018 10:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@emilyalbini@rust-highfive@petrochenkov@bors@Mark-Simulacrum@kennytm@michaelwoerister