Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #48017
Merged
Merged
Conversation
kennytm
commented
Feb 5, 2018
Member
- Successful merges: Make inline assembly volatile if it has no outputs. Fixes #46026 #46030, add documentation from doc(include) to analysis data #47496, Disallow mutable borrow to non-mut statics #47543, Add a regression test for #44415 #47704, Update book #47753, Make wording around 0-cost casts more precise #47807, Stabilize use_nested_groups #47948, Fix rustdoc ICE on macros defined within functions #47959, Fix info about generic impls in AsMut docs #48003, save-analysis: avoid implicit unwrap #48007
- Failed merges:
This path was considered to be unreachable. However, `&mut` could potentially live inside `static`. For example, `static TAB: [&mut [u8]; 0] = [];`.
This text was copy-pasted from the `AsRef` docs to `AsMut`, but needed some additional adjustments for correctness.
and improve printing of errors
When looking up a field defintion, since the name might be incorrect in the field init shorthand case. cc rust-lang/rls#699
Make inline assembly volatile if it has no outputs. Fixesrust-lang#46026
…estebank add documentation from doc(include) to analysis data cc rust-lang#44732 Currently save-analysis only loads docs from plain doc comments and doc attributes. Since `#[doc(include="filename.md")]` doesn't create a plain doc attribute when it loads the file, we need to be sure to pick up this info for the analysis data.
…akis Disallow mutable borrow to non-mut statics Closesrust-lang#42344.
Add a regression test for rust-lang#44415 This PR adds a regression test for issue rust-lang#44415. Fixesrust-lang#44415.
…chton Update book This PR does two things: 1. update the book to include rust-lang/book#1088 2. update to mdbook 0.1 Both of these things are big changes, so I want to land them now, well before the next branch, so we can kick the tires. ------------------------------ Locally, I'm seeing some weirdness around the reference and this:  Putting this PR up so others can try and build and see if it reproduces for them.
…eveklabnik Make wording around 0-cost casts more precise
…ilize, r=petrochenkov Stabilize use_nested_groups As requested in rust-lang#44494. Documentation PRs already sent.
…ulacrum Fix rustdoc ICE on macros defined within functions fixesrust-lang#47639
Fix info about generic impls in AsMut docs This text was copy-pasted from the `AsRef` docs to `AsMut`, but needed some additional adjustments for correctness.
save-analysis: avoid implicit unwrap When looking up a field defintion, since the name might be incorrect in the field init shorthand case. cc rust-lang/rls#699 r? @eddyb
rust-highfive
commented
Feb 5, 2018
Contributor
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
commented
Feb 5, 2018
MemberAuthor
@bors r+ p=2 |
bors
commented
Feb 5, 2018
Collaborator
📌 Commit 0553dc8 has been approved by |
bors
commented
Feb 5, 2018
Collaborator
⌛ Testing commit 0553dc8 with merge 759ae2d61ccb535e05fa38c12585a21aa14994b5... |
bors
commented
Feb 5, 2018
Collaborator
💔 Test failed - status-appveyor |
kennytm
commented
Feb 6, 2018
MemberAuthor
bors
commented
Feb 6, 2018
Collaborator
bors
commented
Feb 6, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.