Implement Integer methods for Wrapping by Phlosioneer · Pull Request #48810 · rust-lang/rust

Phlosioneer · 2018-03-07T04:24:02Z

Wrapping now implements:

count_ones, count_zeros, leading_zeros,
trailing_zeros, rotate_left, rotate_right, swap_bytes, from_be,
from_le, to_be, to_le, and pow

where T is:

u8, u16, u32, u64, usize, i8, i16, i32, i64, or isize.

Docs were written for all these methods, as well as examples. The
examples mirror the ones on u8, u16, etc... for consistency.

Closes#32463

rust-highfive · 2018-03-07T04:24:15Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Phlosioneer · 2018-03-07T04:26:58Z

Because of the last comment on #32463, I think dtolnay is probably the best person to review this.

r? @dtolnay

scottmcm · 2018-03-07T05:21:25Z

+ #[inline]
+ #[unstable(feature = "wrapping_int_impl", issue = "32463")]
+ pub fn pow(self, exp: u32) -> Self {
+ Wrapping(self.0.pow(exp))


I think this one should call wrapping_pow? And maybe include a doctest demonstrating that it wraps...

I wanted to name it pow to mirror the names on u8 etc. These impls are intended to make generic code that operates on integer types work seamlessly with wrapping integer types, and that requires the method names to be the same.
I'll add a wrapping example to the doctest.

I think @scottmcm meant that within, it should call self.0.wrapping_pow(exp). Otherwise, it might actually overflow / panic.

scottmcm · 2018-03-07T05:23:02Z

 }
+
+
+


[00:06:04] tidy error: /checkout/src/libcore/num/wrapping.rs:528: trailing whitespace
[00:06:04] tidy error: /checkout/src/libcore/num/wrapping.rs: too many trailing newlines (4)

dtolnay

Thanks!

dtolnay · 2018-03-10T18:59:27Z

@bors r+

bors · 2018-03-10T18:59:28Z

📌 Commit 910d855 has been approved by dtolnay

…wrapping, r=dtolnay Implement Integer methods for Wrapping Wrapping<T> now implements: count_ones, count_zeros, leading_zeros, trailing_zeros, rotate_left, rotate_right, swap_bytes, from_be, from_le, to_be, to_le, and pow where T is: u8, u16, u32, u64, usize, i8, i16, i32, i64, or isize. Docs were written for all these methods, as well as examples. The examples mirror the ones on u8, u16, etc... for consistency. Closesrust-lang#32463

kennytm · 2018-03-11T08:02:51Z

@bors rollup

…wrapping, r=dtolnay Implement Integer methods for Wrapping Wrapping<T> now implements: count_ones, count_zeros, leading_zeros, trailing_zeros, rotate_left, rotate_right, swap_bytes, from_be, from_le, to_be, to_le, and pow where T is: u8, u16, u32, u64, usize, i8, i16, i32, i64, or isize. Docs were written for all these methods, as well as examples. The examples mirror the ones on u8, u16, etc... for consistency. Closesrust-lang#32463

kennytm · 2018-03-13T15:26:02Z

@bors rollup-

bors · 2018-03-14T04:20:37Z

⌛ Testing commit 910d855 with merge 2b0dbffed5e11b4b565e4011d77ccf12493bd82b...

bors · 2018-03-14T05:52:10Z

💔 Test failed - status-travis

Phlosioneer · 2018-03-14T06:05:58Z

Is there something wrong with my PR...? A rollup error log doesn't usually show up directly under a PR. The error is weird, though... something about duplicate rustdoc for impl<T> Send for Outer<T> where T: Copy + Send?

scottmcm · 2018-03-14T07:52:47Z

@Phlosioneer It was removed from the rollup, see #48810 (comment)

(I don't understand the error either.)

Phlosioneer · 2018-03-16T19:25:24Z

uhm, what do I need to do? I don't think this is waiting-on-author...

kennytm · 2018-03-16T20:19:39Z

@Phlosioneer Try to change rustdoc/synthetic_auto/no-redundancy.rs to match either Copy + Send or Send + Copy. You can use @matches with a regular expression, see htmldocck.py for syntax. I suspect this is the same issue as #48265 (review).

(cc @GuillaumeGomez about the order change on i686.)

SimonSapin · 2018-03-17T23:03:59Z

I’ve filed #49123 for that rustdoc test failure.

Wrapping<T> now implements: count_ones, count_zeros, leading_zeros, trailing_zeros, rotate_left, rotate_right, swap_bytes, from_be, from_le, to_be, to_le, and pow where T is: u8, u16, u32, u64, usize, i8, i16, i32, i64, or isize. Docs were written for all these methods, as well as examples. The examples mirror the ones on u8, u16, etc... for consistency. Closesrust-lang#32463

Phlosioneer · 2018-03-19T05:42:31Z

I rebased against master, and I don't see #49123 during local testing. We'll see if travis agrees.

GuillaumeGomez · 2018-03-19T09:09:13Z

I have no idea why there is a change in the order... If there is a problem, I think it comes from the internals of rust instead of rustdoc.

kennytm · 2018-03-19T09:24:50Z

@bors r=dtolnay

Let's try again then.

bors · 2018-03-19T09:24:51Z

📌 Commit bf101a5 has been approved by dtolnay

…wrapping, r=dtolnay Implement Integer methods for Wrapping Wrapping<T> now implements: count_ones, count_zeros, leading_zeros, trailing_zeros, rotate_left, rotate_right, swap_bytes, from_be, from_le, to_be, to_le, and pow where T is: u8, u16, u32, u64, usize, i8, i16, i32, i64, or isize. Docs were written for all these methods, as well as examples. The examples mirror the ones on u8, u16, etc... for consistency. Closesrust-lang#32463

kennytm · 2018-03-20T03:45:57Z

@bors rollup

Rollup of 17 pull requests - Successful merges: #46518, #48810, #48834, #48902, #49004, #49092, #49096, #49099, #49104, #49125, #49139, #49152, #49157, #49161, #49166, #49176, #49184 - Failed merges:

rust-highfive assigned BurntSushi Mar 7, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2018

rust-highfive assigned dtolnay and unassigned BurntSushi Mar 7, 2018

scottmcm reviewed Mar 7, 2018
View reviewed changes

Phlosioneer force-pushed the 32463-impl-integer-for-wrapping branch from afb1870 to 02aa39fCompare March 8, 2018 07:36

dtolnay approved these changes Mar 10, 2018
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2018

kennytm mentioned this pull request Mar 10, 2018
Rollup of 7 pull requests #48921
Closed

Mark-Simulacrum mentioned this pull request Mar 12, 2018
Rollup of 8 pull requests #48947
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2018

kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 14, 2018

kennytm removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2018

SimonSapin mentioned this pull request Mar 18, 2018
Rustdoc: where bounds order in synthetic impls is not deterministic #49123
Closed

Phlosioneer added 3 commits March 19, 2018 01:39

Make Wrapping::pow use wrapping_pow, add example
5258af3

Fix trailing whitespace
bf101a5

Phlosioneer force-pushed the 32463-impl-integer-for-wrapping branch from 910d855 to bf101a5Compare March 19, 2018 05:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2018

kennytm mentioned this pull request Mar 19, 2018
Rollup of 17 pull requests #49190
Merged

bors merged commit bf101a5 into rust-lang:masterMar 20, 2018

Uh oh!

Uh oh!

Conversation

Phlosioneer commented Mar 7, 2018

Uh oh!

rust-highfive commented Mar 7, 2018

Uh oh!

Phlosioneer commented Mar 7, 2018

Uh oh!

scottmcmMar 7, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PhlosioneerMar 7, 2018

Choose a reason for hiding this comment

Uh oh!

cuviperMar 7, 2018

Choose a reason for hiding this comment

Uh oh!

scottmcmMar 7, 2018

Choose a reason for hiding this comment

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Mar 10, 2018

Uh oh!

bors commented Mar 10, 2018

Uh oh!

kennytm commented Mar 11, 2018

Uh oh!

kennytm commented Mar 13, 2018

Uh oh!

bors commented Mar 14, 2018

Uh oh!

bors commented Mar 14, 2018

Uh oh!

Phlosioneer commented Mar 14, 2018

Uh oh!

scottmcm commented Mar 14, 2018

Uh oh!

Phlosioneer commented Mar 16, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennytm commented Mar 16, 2018

Uh oh!

SimonSapin commented Mar 17, 2018

Uh oh!

Phlosioneer commented Mar 19, 2018

Uh oh!

GuillaumeGomez commented Mar 19, 2018

Uh oh!

kennytm commented Mar 19, 2018

Uh oh!

bors commented Mar 19, 2018

Uh oh!

kennytm commented Mar 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

scottmcmMar 7, 2018•
edited
Loading

Phlosioneer commented Mar 16, 2018•
edited
Loading