Skip to content

rustbuild: Ship libsynchronization - #49125

Merged
bors merged 1 commit into
rust-lang:masterfrom
NovemberZulu:master
Mar 20, 2018
Merged

rustbuild: Ship libsynchronization#49125
bors merged 1 commit into
rust-lang:masterfrom
NovemberZulu:master

Conversation

@NovemberZulu

@NovemberZuluNovemberZulu commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

Hot on the heels of #49044 comes similar issue with libsynchronization. Discovered while building clippy:

<skipped>
Compiling serde_derive v1.0.33
error: linking with `gcc` failed: exit code: 1
<skipped>
= note: ld: cannot find -lsynchronization

r? @nikomatsakis

@NovemberZulu
rustbuild: Ship libsynchronization
1e73c1d
Ship libsynchronization from MinGW
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2018
@messensemessense mentioned this pull request Mar 18, 2018
Merged
@alexcrichton

alexcrichton commented Mar 18, 2018

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 18, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 1e73c1d has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 19, 2018
@kennytm
Rollup merge ofrust-lang#49125- NovemberZulu:master, r=alexcrichton
baea60b
rustbuild: Ship libsynchronization
Hot on the heels of rust-lang#49044 comes similar issue with libsynchronization. Discovered while building clippy:
```
<skipped>
Compiling serde_derive v1.0.33
error: linking with `gcc` failed: exit code: 1
<skipped>
= note: ld: cannot find -lsynchronization
```
r? @nikomatsakis
@kennytmkennytm mentioned this pull request Mar 19, 2018
Merged
bors added a commit that referenced this pull request Mar 20, 2018
@bors
Auto merge of#49190- kennytm:rollup, r=kennytm
75af15e
Rollup of 17 pull requests
- Successful merges: #46518, #48810, #48834, #48902, #49004, #49092, #49096, #49099, #49104, #49125, #49139, #49152, #49157, #49161, #49166, #49176, #49184
- Failed merges:
@bors
bors merged commit 1e73c1d into rust-lang:masterMar 20, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NovemberZulu@alexcrichton@bors@nikomatsakis@rust-highfive