Skip to content

Cache the specialization_graph query - #49004

Merged
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:incr_specialization_graph_query
Mar 20, 2018
Merged

Cache the specialization_graph query#49004
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:incr_specialization_graph_query

Conversation

@wesleywiser

@wesleywiserwesleywiser commented Mar 14, 2018

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2018
@michaelwoerister

michaelwoerister commented Mar 14, 2018

Copy link
Copy Markdown
Member

Perfect! :)

@bors try

@bors

bors commented Mar 14, 2018

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 311bb10 with merge e744f7e...

bors added a commit that referenced this pull request Mar 14, 2018
@bors
Auto merge of#49004- wesleywiser:incr_specialization_graph_query, r…
e744f7e
…=<try>
Cache the specialization_graph query
Fixes#48987
r? @michaelwoerister
@bors

bors commented Mar 14, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
State: approved= try=True

@michaelwoerister

michaelwoerister commented Mar 14, 2018

Copy link
Copy Markdown
Member

@Mark-Simulacrum, could you do a perf-run please? Just to make sure this doesn't regress anything.

@Mark-Simulacrum

Mark-Simulacrum commented Mar 14, 2018

Copy link
Copy Markdown
Member

Perf started.

@michaelwoerister

michaelwoerister commented Mar 14, 2018

Copy link
Copy Markdown
Member

Link: http://perf.rust-lang.org/compare.html?start=fab632f9759af4f3d96c6ec69e24e5428060dba4&end=e744f7efcbdd9caf5dafe6bfaa813fa6aaec2aba&stat=instructions%3Au

@wesleywiser
wesleywiserforce-pushed the incr_specialization_graph_query branch from 311bb10 to 5766e71CompareMarch 15, 2018 01:02
@michaelwoerister

michaelwoerister commented Mar 15, 2018

Copy link
Copy Markdown
Member

@Mark-Simulacrum, I think something has gone wrong with the perf-run.

@Mark-Simulacrum

Mark-Simulacrum commented Mar 15, 2018

Copy link
Copy Markdown
Member

I've added even more debugging and restarted it.. not sure what went wrong.

@michaelwoerister

michaelwoerister commented Mar 16, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Still doesn't work :(

@Mark-Simulacrum

Mark-Simulacrum commented Mar 16, 2018

Copy link
Copy Markdown
Member

Restarted again this time the logging is confirmed to work. Turns out env_logger doesn't send output to stdout...

@Mark-Simulacrum

Mark-Simulacrum commented Mar 16, 2018

Copy link
Copy Markdown
Member

It worked: http://perf.rust-lang.org/compare.html?start=fab632f9759af4f3d96c6ec69e24e5428060dba4&end=e744f7efcbdd9caf5dafe6bfaa813fa6aaec2aba&stat=instructions%3Au.

No ideas on what went wrong before, but I guess we at least have logging now.

@michaelwoerister

michaelwoerister commented Mar 19, 2018

Copy link
Copy Markdown
Member

Thanks @Mark-Simulacrum!

The results are not spectacular but pretty much in line with what I expected.

@bors r+

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 5766e71 has been approved by michaelwoerister

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 19, 2018
@kennytm
Rollup merge ofrust-lang#49004- wesleywiser:incr_specialization_gra…
28eced1
…ph_query, r=michaelwoerister
Cache the specialization_graph query
Fixesrust-lang#48987
r? @michaelwoerister
@kennytmkennytm mentioned this pull request Mar 19, 2018
Merged
bors added a commit that referenced this pull request Mar 20, 2018
@bors
Auto merge of#49190- kennytm:rollup, r=kennytm
75af15e
Rollup of 17 pull requests
- Successful merges: #46518, #48810, #48834, #48902, #49004, #49092, #49096, #49099, #49104, #49125, #49139, #49152, #49157, #49161, #49166, #49176, #49184
- Failed merges:
@bors
bors merged commit 5766e71 into rust-lang:masterMar 20, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoeristermichaelwoerister

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wesleywiser@michaelwoerister@bors@Mark-Simulacrum@rust-highfive