Skip to content

Implement import renaming with _ (RFC 2166) - #48922

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:asunder
Mar 16, 2018
Merged

Implement import renaming with _ (RFC 2166)#48922
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:asunder

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Mar 10, 2018

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Mar 10, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2018
nikomatsakis
nikomatsakis approved these changes Mar 12, 2018
View reviewed changes
Comment threadsrc/libsyntax/parse/parser.rs Outdated

@nikomatsakisnikomatsakisMar 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man what a hack. But clever =)

@nikomatsakis

nikomatsakis commented Mar 12, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e351288 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2018
@nikomatsakis

nikomatsakis commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 13, 2018
@nikomatsakis

nikomatsakis commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

er, mistake, sorry

@nikomatsakis

nikomatsakis commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 13, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e351288 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2018
@kennytm

kennytm commented Mar 14, 2018

Copy link
Copy Markdown
Member

@bors r-

The UI tests in this PR will be broken by the rephrasing in #48684. Please rebase and update src/test/ui/feature-gate-underscore-imports.stderr. The last line should read

For more information about this error, try `rustc --explain E0658`.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2018
@petrochenkov

petrochenkov commented Mar 14, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented Mar 14, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 12ac032 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 15, 2018
@kennytm
Rollup merge ofrust-lang#48922- petrochenkov:asunder, r=nikomatsakis
e1d19df
Implement import renaming with `_` (RFC 2166)
cc rust-lang#48216
@kennytmkennytm mentioned this pull request Mar 15, 2018
Merged
bors added a commit that referenced this pull request Mar 16, 2018
@bors
Auto merge of#49051- kennytm:rollup, r=kennytm
36b6687
Rollup of 17 pull requests
- Successful merges: #48706, #48875, #48892, #48922, #48957, #48959, #48961, #48965, #49007, #49024, #49042, #49050, #48853, #48990, #49037, #49049, #48972
- Failed merges:
@bors
bors merged commit 12ac032 into rust-lang:masterMar 16, 2018
This was referenced Oct 8, 2018
Closed
Merged
@petrochenkovpetrochenkov mentioned this pull request Nov 28, 2018
Merged
@CentrilCentril mentioned this pull request May 30, 2019
Merged
@petrochenkov
petrochenkov deleted the asunder branch June 5, 2019 16:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@rust-highfive@nikomatsakis@bors@kennytm