Skip to content

Coherence diagnostic tweaks - #49037

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:coherence-tweaks
Mar 16, 2018
Merged

Coherence diagnostic tweaks#49037
bors merged 1 commit into
rust-lang:masterfrom
estebank:coherence-tweaks

Conversation

@estebank

@estebankestebank commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2018
@eddyb

eddyb commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

nikomatsakis
nikomatsakis approved these changes Mar 15, 2018
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once travis is happy

@nikomatsakisnikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2018
@estebank

estebank commented Mar 15, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis rollup

@bors

bors commented Mar 15, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 4d5cd21 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 15, 2018
@kennytmkennytm mentioned this pull request Mar 15, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 15, 2018
@kennytm
Rollup merge ofrust-lang#49037- estebank:coherence-tweaks, r=nikoma…
a199fb2
…tsakis
Coherence diagnostic tweaks
bors added a commit that referenced this pull request Mar 16, 2018
@bors
Auto merge of#49051- kennytm:rollup, r=kennytm
36b6687
Rollup of 17 pull requests
- Successful merges: #48706, #48875, #48892, #48922, #48957, #48959, #48961, #48965, #49007, #49024, #49042, #49050, #48853, #48990, #49037, #49049, #48972
- Failed merges:
@bors
bors merged commit 4d5cd21 into rust-lang:masterMar 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@estebank@rust-highfive@eddyb@bors@nikomatsakis