Skip to content

Fix ICE on malformed plugin attributes - #48990

Merged
bors merged 2 commits into
rust-lang:masterfrom
exphp-forks:dont-drop-the-bomb
Mar 16, 2018
Merged

Fix ICE on malformed plugin attributes#48990
bors merged 2 commits into
rust-lang:masterfrom
exphp-forks:dont-drop-the-bomb

Conversation

@ExpHP

@ExpHPExpHP commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

See #48941 for some discussion.

This bug had several duplicate reports which were never closed as dupes:

Fixes#47612
Fixes#48387
Fixes#48941
Fixes#48982

@rust-highfive

rust-highfive commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2018
@ExpHP

ExpHP commented Mar 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Note: The expect in the MultiDecorator branch is there because, try as I might, I could not come up a test case where ok() failed there. (if it ever fails in the future, it will be easier to debug now that it does not drop the DiagnosticBuilder)

It is only my assumption that rustc is bailing out at an earlier stage after it fails to parse the list of traits in #[derive(...)].

@ExpHP

ExpHP commented Mar 13, 2018

Copy link
Copy Markdown
ContributorAuthor

r? @estebank

@estebank

estebank commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

r=me rollup once travis catches up

@estebank

estebank commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 15, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit dc96467 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2018
@kennytmkennytm mentioned this pull request Mar 15, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 15, 2018
@kennytm
Rollup merge ofrust-lang#48990- ExpHP:dont-drop-the-bomb, r=estebank
64490ff
Fix ICE on malformed plugin attributes
See rust-lang#48941 for some discussion.
This bug had several duplicate reports which were never closed as dupes:
Fixesrust-lang#47612Fixesrust-lang#48387Fixesrust-lang#48941Fixesrust-lang#48982
bors added a commit that referenced this pull request Mar 16, 2018
@bors
Auto merge of#49051- kennytm:rollup, r=kennytm
36b6687
Rollup of 17 pull requests
- Successful merges: #48706, #48875, #48892, #48922, #48957, #48959, #48961, #48965, #49007, #49024, #49042, #49050, #48853, #48990, #49037, #49049, #48972
- Failed merges:
@bors
bors merged commit dc96467 into rust-lang:masterMar 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

5 participants

@ExpHP@rust-highfive@estebank@bors@michaelwoerister