Update clap by matklad · Pull Request #49182 · rust-lang/rust

matklad · 2018-03-19T19:00:10Z

This should fix a regression in Cargo after swithing to clap, when
an external subcommand was not discovered, if its name was close to
a built in command.

bug report: #48986 (comment)
fix: clap-rs/clap#1215

rust-highfive · 2018-03-19T19:00:17Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

matklad · 2018-03-19T19:00:58Z

r? @kennytm

kennytm · 2018-03-19T20:01:16Z

@bors r+ p=1

(Fixes regression, this p is higher)

@matklad I think cargo itself should later add a test to ensure cargo install-update will actually call the 3rd party executable though.

bors · 2018-03-19T20:01:17Z

📌 Commit f88820e has been approved by kennytm

matklad · 2018-03-19T20:14:33Z

Seems most reasonable, @kennytm: rust-lang/cargo#5207!

matklad · 2018-03-19T20:56:14Z

@bors r-

A test in Cargo would fail with a new clap =)

matklad · 2018-03-20T00:40:15Z

Clap is updated in Cargo, however I want to include rust-lang/cargo#5209 as well, which fixes a much more serious regression.

matklad · 2018-03-20T07:41:55Z

Updated with the latest and greatest Cargo with regressions fixed!

kennytm · 2018-03-20T11:19:29Z

@bors r+

bors · 2018-03-20T11:19:30Z

📌 Commit 40ac331 has been approved by kennytm

bors · 2018-03-20T12:50:48Z

🔒 Merge conflict

This should fix regressions in Cargo after swithing to clap: * If an external subcommand name was close to built-in one, clap errored (fixed by updating clap version) * External subcomands didn't received their name as a first arg

bors · 2018-03-20T15:54:10Z

💔 Test failed - status-travis

kennytm · 2018-03-20T15:56:44Z

@bors retry

travis-ci/dpl is still broken even after released 1.9.3.

/home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-s3-1.9.3/lib/dpl/provider/s3.rb:108:in `rescue in deploy': uninitialized constant Aws::S3::Errors (NameError)

bors · 2018-03-20T17:14:39Z

⌛ Testing commit 8d97747 with merge da79a95...

Update clap This should fix a regression in Cargo after swithing to clap, when an external subcommand was not discovered, if its name was close to a built in command. bug report: #48986 (comment)fix: clap-rs/clap#1215

bors · 2018-03-20T18:40:11Z

💔 Test failed - status-travis

kennytm · 2018-03-20T19:04:16Z

@bors retry travis-ci/dpl#788

bors · 2018-03-20T20:10:35Z

⌛ Testing commit 8d97747 with merge a76d9c7...

Update clap This should fix a regression in Cargo after swithing to clap, when an external subcommand was not discovered, if its name was close to a built in command. bug report: #48986 (comment)fix: clap-rs/clap#1215

bors · 2018-03-20T21:22:16Z

💔 Test failed - status-travis

kennytm · 2018-03-20T22:16:56Z

@bors retry travis-ci/dpl#788

Update clap This should fix a regression in Cargo after swithing to clap, when an external subcommand was not discovered, if its name was close to a built in command. bug report: rust-lang#48986 (comment)fix: clap-rs/clap#1215

Rollup of 3 pull requests - Successful merges: #49182, #49196, #49217 - Failed merges:

rust-highfive assigned aturon Mar 19, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2018

rust-highfive assigned kennytm and unassigned aturon Mar 19, 2018

matklad mentioned this pull request Mar 19, 2018
Clap update broke some external subcommands rust-lang/cargo#5201
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2018

matklad force-pushed the update-clap branch from f88820e to 40ac331Compare March 20, 2018 07:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2018

matklad mentioned this pull request Mar 20, 2018
cargo plugin sub commands no longer work in nightly version rust-lang/cargo#5212
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018

Update Cargo to fix regression
8d97747
This should fix regressions in Cargo after swithing to clap: * If an external subcommand name was close to built-in one, clap errored (fixed by updating clap version) * External subcomands didn't received their name as a first arg

matklad force-pushed the update-clap branch from 40ac331 to 8d97747Compare March 20, 2018 13:00

matklad closed this Mar 20, 2018

matklad reopened this Mar 20, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018

kennytm mentioned this pull request Mar 20, 2018
Rollup of 3 pull requests #49221
Merged

bors added a commit that referenced this pull request Mar 20, 2018
Auto merge of#49221- kennytm:rollup, r=kennytm
1042053
Rollup of 3 pull requests - Successful merges: #49182, #49196, #49217 - Failed merges:

Frederick888 mentioned this pull request Mar 21, 2018
Always fails with "Invalid arguments." on nightly 2018-03-19 kbknapp/cargo-outdated#128
Closed

bors merged commit 8d97747 into rust-lang:masterMar 21, 2018

matklad deleted the update-clap branch March 21, 2018 08:02

hdhoang mentioned this pull request Mar 21, 2018
cargo bloat has broken ah-/anne-key#47
Closed

Uh oh!

Uh oh!

Conversation

matklad commented Mar 19, 2018

Uh oh!

rust-highfive commented Mar 19, 2018

Uh oh!

matklad commented Mar 19, 2018

Uh oh!

kennytm commented Mar 19, 2018

Uh oh!

bors commented Mar 19, 2018

Uh oh!

matklad commented Mar 19, 2018

Uh oh!

matklad commented Mar 19, 2018

Uh oh!

matklad commented Mar 20, 2018

Uh oh!

matklad commented Mar 20, 2018

Uh oh!

kennytm commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

kennytm commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

kennytm commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

bors commented Mar 20, 2018

Uh oh!

kennytm commented Mar 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants