Uh oh!
There was an error while loading. Please reload this page.
Fix ordering of auto-generated trait bounds in rustdoc output - #49196
Merged
Conversation
While the order of the where clauses was deterministic, the ordering of bounds and lifetimes was not. This made the order flip- flop randomly when new traits and impls were added to libstd. This PR makes the ordering of bounds and lifetimes deterministic, and re-enables the test that was causing the issue. Fixesrust-lang#49123
Phlosioneer
commented
Mar 20, 2018
ContributorAuthor
QuietMisdreavus
commented
Mar 20, 2018
Contributor
Great! Thanks for getting this set up! @bors r+ p=1 (fixes a flaky test) |
bors
commented
Mar 20, 2018
Collaborator
📌 Commit 7daf3f9 has been approved by |
bors
commented
Mar 20, 2018
Collaborator
bors added a commit
that referenced
this pull request
Mar 20, 2018
…etMisdreavus Fix ordering of auto-generated trait bounds in rustdoc output While the order of the where clauses was deterministic, the ordering of bounds and lifetimes was not. This made the order flip- flop randomly when new traits and impls were added to libstd. This PR makes the ordering of bounds and lifetimes deterministic, and re-enables the test that was causing the issue. Fixes#49123
bors
commented
Mar 20, 2018
Collaborator
💔 Test failed - status-travis |
kennytm
commented
Mar 20, 2018
Member
@bors retry |
bors
commented
Mar 20, 2018
Collaborator
⌛ Testing commit 7daf3f9 with merge 72da16c27ea66d734b4fd058ef03acfa41b1cadb... |
bors
commented
Mar 20, 2018
Collaborator
💔 Test failed - status-travis |
QuietMisdreavus
commented
Mar 20, 2018
Contributor
Currently waiting on #49217 or some other resolution to travis-ci/dpl#788... |
kennytm
commented
Mar 20, 2018
Member
@bors retry travis-ci/dpl#788 |
bors
commented
Mar 20, 2018
Collaborator
⌛ Testing commit 7daf3f9 with merge 33a0ca2a3c6574e258f184b237ee301e4c9948f2... |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Mar 20, 2018
…ions, r=QuietMisdreavus Fix ordering of auto-generated trait bounds in rustdoc output While the order of the where clauses was deterministic, the ordering of bounds and lifetimes was not. This made the order flip- flop randomly when new traits and impls were added to libstd. This PR makes the ordering of bounds and lifetimes deterministic, and re-enables the test that was causing the issue. Fixesrust-lang#49123
kennytm
commented
Mar 20, 2018
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the order of the where clauses was deterministic, the
ordering of bounds and lifetimes was not. This made the order flip-
flop randomly when new traits and impls were added to libstd.
This PR makes the ordering of bounds and lifetimes deterministic,
and re-enables the test that was causing the issue.
Fixes#49123