Uh oh!
There was an error while loading. Please reload this page.
Rollup of 3 pull requests - #49221
Merged
Merged
Conversation
kennytm
commented
Mar 20, 2018
Member
- Successful merges: Update clap #49182, Fix ordering of auto-generated trait bounds in rustdoc output #49196, Apply temporary fix of travis-ci/dpl#788. #49217
- Failed merges:
While the order of the where clauses was deterministic, the ordering of bounds and lifetimes was not. This made the order flip- flop randomly when new traits and impls were added to libstd. This PR makes the ordering of bounds and lifetimes deterministic, and re-enables the test that was causing the issue. Fixesrust-lang#49123
This should fix regressions in Cargo after swithing to clap: * If an external subcommand name was close to built-in one, clap errored (fixed by updating clap version) * External subcomands didn't received their name as a first arg
Update clap This should fix a regression in Cargo after swithing to clap, when an external subcommand was not discovered, if its name was close to a built in command. bug report: rust-lang#48986 (comment)fix: clap-rs/clap#1215
…ions, r=QuietMisdreavus Fix ordering of auto-generated trait bounds in rustdoc output While the order of the where clauses was deterministic, the ordering of bounds and lifetimes was not. This made the order flip- flop randomly when new traits and impls were added to libstd. This PR makes the ordering of bounds and lifetimes deterministic, and re-enables the test that was causing the issue. Fixesrust-lang#49123
Apply temporary fix of travis-ci/dpl#788.
rust-highfive
commented
Mar 20, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Mar 20, 2018
Contributor
|
kennytm
commented
Mar 20, 2018
MemberAuthor
@bors r+ p=300 We are retrying these for too long today, let's merge them altogether. |
bors
commented
Mar 20, 2018
Collaborator
📌 Commit de9fb3b has been approved by |
bors
commented
Mar 20, 2018
Collaborator
bors
commented
Mar 21, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
kennytm-githubbot
commented
Mar 21, 2018
kennytm-githubbot added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Mar 21, 2018
Tested on commit rust-lang/rust@1042053. Direct link to PR: <rust-lang/rust#49221> 💔 rls on windows: test-pass → build-fail (cc @nrc). 💔 rls on linux: test-pass → build-fail (cc @nrc).
This was referenced Mar 21, 2018
Merged
Mark-Simulacrum
commented
Mar 21, 2018
Member
@nrc Since this is the week before beta branch, can you prioritize a fix for the RLS? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.