Uh oh!
There was an error while loading. Please reload this page.
Don't abort const eval due to long running evals, just warn - #49947
Merged
Conversation
nagisa
approved these changes
Apr 14, 2018
nagisa
left a comment
Member
There was a problem hiding this comment.
r=me with an issue and a comment.
| pub fn inc_step_counter_and_check_limit(&mut self, n: usize) { | ||
| self.terminators_remaining = self.terminators_remaining.saturating_sub(n); | ||
| if self.terminators_remaining == 0 { | ||
| self.tcx.sess.span_warn(self.frame().span, "Constant evaluating a complex constant, this might take some time"); |
Member
There was a problem hiding this comment.
Can you fill an issue that raises a question of making this a lint-warning and link the issue with a comment here?
oli-obk
commented
Apr 15, 2018
ContributorAuthor
@bors r=nagisa |
bors
commented
Apr 15, 2018
Collaborator
📌 Commit 907df8c has been approved by |
bors
commented
Apr 15, 2018
Collaborator
bors added a commit
that referenced
this pull request
Apr 15, 2018
Don't abort const eval due to long running evals, just warn one check-box of #49930 r? @nagisa (rust-lang/rfcs#2344 (comment))
bors
commented
Apr 16, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
commented
Apr 20, 2018
Member
Backported in #50027 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one check-box of #49930
r? @nagisa (rust-lang/rfcs#2344 (comment))