[beta] backport various PRs by oli-obk · Pull Request #50027 · rust-lang/rust

oli-obk · 2018-04-17T13:56:29Z

original PRs:

Sign extend constants in range patterns #49949 (not yet merged at the time of writing)
Don't abort const eval due to long running evals, just warn #49947 (long running const eval error -> warning)
Don't recurse into allocations, use a global table instead #49833 (static recursion)
Don't inject clippy into rls on stable/beta #49876 (no clippy in stable rls)
Work around LLVM debuginfo problem in librustc_driver. #49904 (Work around LLVM debuginfo problem in librustc_driver. )

rust-highfive · 2018-04-17T13:56:33Z

Warning

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

oli-obk · 2018-04-17T17:32:50Z

r? @kennytm

all merged into one now

oli-obk · 2018-04-17T18:32:49Z

cc @rust-lang/compiler a beta backport of the various fixes for miri+incremental ICEs

kennytm · 2018-04-17T19:30:05Z

@bors r+ p=4

bors · 2018-04-17T19:30:06Z

📌 Commit 7e2aada has been approved by kennytm

kennytm · 2018-04-17T19:34:34Z

@bors r-

Err wait, let's ensure that #49949 is successfully merged first.

Also, #49949, #49947 and #49833 are missing the beta-accepted labels for rubber-stamping the backport.

…ans::LOAD.

kennytm · 2018-04-19T11:25:47Z

@bors r+

bors · 2018-04-19T11:25:48Z

📌 Commit 7e2aada has been approved by kennytm

oli-obk · 2018-04-19T11:31:43Z

we don't have rubber stamps yet...

bors · 2018-04-19T13:39:11Z

⌛ Testing commit 7e2aada with merge 8d3e0c17b09936d52c8696e86e53bd44fe83f7db...

nagisa · 2018-04-19T15:16:47Z

everything has been stamped.

…

On Thu, Apr 19, 2018, 16:39 bors ***@***.***> wrote: ⌛️ Testing commit 7e2aada <7e2aada> with merge 8d3e0c1 <8d3e0c1> ... — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#50027 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApc0poPOSRkBvNpKW6CydbRRHCrVkXkks5tqJOcgaJpZM4TYW6R> .

bors · 2018-04-19T16:39:53Z

💔 Test failed - status-travis

emilyalbini · 2018-04-19T16:42:54Z

Timed out on Travis IMAGE=x86_64-gnu-incremental.

@bors retry

… r=alexcrichton Backport of rust-lang#49904 See rust-lang#49904.

kennytm · 2018-04-19T18:58:38Z

@bors r+

Rolled up #50046 here.

bors · 2018-04-19T18:58:38Z

📌 Commit 0f4bb2f has been approved by kennytm

kennytm · 2018-04-19T19:02:38Z

@bors p=5

bors · 2018-04-19T19:35:54Z

⌛ Testing commit 0f4bb2f with merge 8423230...

[beta] backport various PRs original PRs: * #49949 (not yet merged at the time of writing) * #49947 (long running const eval error -> warning) * #49833 (static recursion) * #49876 (no clippy in stable rls) * #49904 (Work around LLVM debuginfo problem in librustc_driver. )

bors · 2018-04-19T22:14:30Z

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 8423230 to beta...

oli-obk added 6 commits April 17, 2018 15:40

Don't recurse into allocations, use a global table instead
2546ff8

Stop referring to statics' AllocIds directly
170ea65

Use LazySeq instead of Vec
0734f0e

Encode items before encoding the list of AllocIds
45d5b64

Reduce the number of calls to cdata
84be1fd

Get rid of redundant HashSet
3d1f645

rust-highfive assigned eddyb Apr 17, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2018

Difference between master and beta
a184097

eddyb approved these changes Apr 17, 2018
View reviewed changes

kennytm mentioned this pull request Apr 17, 2018
[beta] Don't inject clippy into rls on stable/beta #50024
Closed

oli-obkand others added 4 commits April 17, 2018 19:27

Sign extend constants in range patterns
2b9e857

Don't abort const eval due to long running evals, just warn
2cc625d

Add a tracking issue for making the warning a lint
2548259

Don't inject clippy into rls on stable/beta
7e2aada

oli-obk force-pushed the const_signed_pat_beta branch from eb81410 to 7e2aadaCompare April 17, 2018 17:30

rust-highfive assigned kennytm and unassigned eddyb Apr 17, 2018

oli-obk changed the title ~~[beta] Sign extend constants in range patterns~~[beta] backport various PRsApr 17, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2018

emilyalbini mentioned this pull request Apr 17, 2018
Constant evaluation regression in beta 1.26 #49930
Closed
2 tasks

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2018

michaelwoerister added 4 commits April 18, 2018 09:55

Add #[no_debug] to trans_fn_attrs() query.
d7b7bda

Support #[no_debug] for global variables.
0ad34dc

Use #[no_debug] to work around LLVM problem with rustc_driver::get_tr…
a95f876
…ans::LOAD.

Clean up attribute handling in create_function_debug_context().
775d70b

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Apr 19, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2018

Rollup merge ofrust-lang#50046- michaelwoerister:backport-no-debug,…
0f4bb2f
… r=alexcrichton Backport of rust-lang#49904 See rust-lang#49904.

bors merged commit 0f4bb2f into rust-lang:betaApr 19, 2018

This was referenced Apr 20, 2018
Sign extend constants in range patterns #49949
Merged
Don't abort const eval due to long running evals, just warn #49947
Merged
Don't recurse into allocations, use a global table instead #49833
Merged

oli-obk deleted the const_signed_pat_beta branch April 23, 2018 09:14

Uh oh!

Uh oh!

Conversation

oli-obk commented Apr 17, 2018• edited by kennytm Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Apr 17, 2018

Uh oh!

oli-obk commented Apr 17, 2018

Uh oh!

oli-obk commented Apr 17, 2018

Uh oh!

kennytm commented Apr 17, 2018

Uh oh!

bors commented Apr 17, 2018

Uh oh!

kennytm commented Apr 17, 2018

Uh oh!

kennytm commented Apr 19, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

oli-obk commented Apr 19, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

nagisa commented Apr 19, 2018 via email

Uh oh!

bors commented Apr 19, 2018

Uh oh!

emilyalbini commented Apr 19, 2018

Uh oh!

kennytm commented Apr 19, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

kennytm commented Apr 19, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

oli-obk commented Apr 17, 2018•
edited by kennytm
Loading