Skip to content

Fix run button style - #51297

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-run-but-style
Jun 3, 2018
Merged

Fix run button style#51297
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-run-but-style

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Jun 2, 2018

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2018
@QuietMisdreavus

QuietMisdreavus commented Jun 2, 2018

Copy link
Copy Markdown
Contributor

Can you provide a screenshot? I don't know what this is going to touch, offhand.

@GuillaumeGomez

GuillaumeGomez commented Jun 2, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I put it back to current (stable/beta) style. Try to hover on the current nightly docs.

@QuietMisdreavus

QuietMisdreavus commented Jun 2, 2018

Copy link
Copy Markdown
Contributor

For posterity:

Light theme, current nightly:

image

Light theme, current stable:

image

Dark theme, current nightly:

image

Dark theme, current stable:

image

Someone looking back at this PR in the future won't be able to see what this change affected. I'm not super comfortable with CSS, and i don't have a perfect understanding of our page layout, so when i see a PR like this i really want to see what it's intended to change.

Since i know you run a Mac, you can use Shift-Command-4 to take a screenshot of just an area of the screen.

@bors r+ rollup

@bors

bors commented Jun 2, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 7585632 has been approved by QuietMisdreavus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 3, 2018
@Mark-Simulacrum
Rollup merge ofrust-lang#51297- GuillaumeGomez:fix-run-but-style, r…
0c695e0
…=QuietMisdreavus
Fix run button style
r? @QuietMisdreavus
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 3, 2018
Merged
bors added a commit that referenced this pull request Jun 3, 2018
@bors
Auto merge of#51319- Mark-Simulacrum:rollup, r=Mark-Simulacrum
3575be6
Rollup of 6 pull requests
Successful merges:
- #51143 (Specify that packed types must derive, not implement, Copy)
- #51226 (Make Layout's align a NonZeroUsize)
- #51297 (Fix run button style)
- #51306 (impl Default for &mut str)
- #51312 (Clarify the difference between get_mut and into_mut for OccupiedEntry)
- #51313 (use type name in E0599 enum variant suggestion)
Failed merges:
@bors
bors merged commit 7585632 into rust-lang:masterJun 3, 2018
@GuillaumeGomez
GuillaumeGomez deleted the fix-run-but-style branch June 3, 2018 10:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@QuietMisdreavusQuietMisdreavus

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@QuietMisdreavus@bors@rust-highfive