Skip to content

use type name in E0599 enum variant suggestion - #51313

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:variant-name-suggestion-fix
Jun 3, 2018
Merged

use type name in E0599 enum variant suggestion#51313
bors merged 1 commit into
rust-lang:masterfrom
euclio:variant-name-suggestion-fix

Conversation

@euclio

Copy link
Copy Markdown
Contributor

Also, rename the variable from "type_str" to "item_kind" to avoid
the ambiguity that caused this bug.

Also, rename the variable from "type_str" to "item_kind" to avoid
the ambiguity that caused this bug.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2018
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 3, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 9eb70c3 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 3, 2018
… r=oli-obk
use type name in E0599 enum variant suggestion
Also, rename the variable from "type_str" to "item_kind" to avoid
the ambiguity that caused this bug.
bors added a commit that referenced this pull request Jun 3, 2018
Rollup of 6 pull requests
Successful merges:
- #51143 (Specify that packed types must derive, not implement, Copy)
- #51226 (Make Layout's align a NonZeroUsize)
- #51297 (Fix run button style)
- #51306 (impl Default for &mut str)
- #51312 (Clarify the difference between get_mut and into_mut for OccupiedEntry)
- #51313 (use type name in E0599 enum variant suggestion)
Failed merges:
@bors
bors merged commit 9eb70c3 into rust-lang:masterJun 3, 2018
@euclio
euclio deleted the variant-name-suggestion-fix branch June 3, 2018 06:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@euclio@rust-highfive@oli-obk@bors@nikomatsakis