Clarify the difference between get_mut and into_mut for OccupiedEntry by frewsxcv · Pull Request #51312 · rust-lang/rust

frewsxcv · 2018-06-02T20:06:47Z

The examples for both hash_map::OccupiedEntry::get_mut and
hash_map::OccupiedEntry::into_mut were almost identical. This led to some
confusion over the difference, namely why you would ever use get_mut when
into_mut gives alonger lifetime. Reddit thread:
https://www.reddit.com/r/rust/comments/8a5swr/why_does_hashmaps

This commit adds two lines and a comment to the example, to show that the
entry object can be re-used after calling get_mut.

Closes#49745

The examples for both hash_map::OccupiedEntry::get_mut and hash_map::OccupiedEntry::into_mut were almost identical. This led to some confusion over the difference, namely why you would ever use get_mut when into_mut gives alonger lifetime. Reddit thread: https://www.reddit.com/r/rust/comments/8a5swr/why_does_hashmaps This commit adds two lines and a comment to the example, to show that the entry object can be re-used after calling get_mut.

rust-highfive · 2018-06-02T20:06:50Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

frewsxcv · 2018-06-02T20:07:09Z

This is a continuation of #49743.

dtolnay

Looks good, thanks.

dtolnay · 2018-06-02T20:16:48Z

@bors r+ rollup

bors · 2018-06-02T20:16:49Z

📌 Commit 5473fb4 has been approved by dtolnay

rust-highfive · 2018-06-02T21:36:24Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:47:01] ...........................................................................i........................
[00:47:06] ....................................................................................................
[00:47:11] ....................................................................................................
[00:47:18] ....................................................................................................
[00:47:22] ........i.................iiiiiiiii...................................................
[00:47:22] [00:47:22] travis_fold:start:test_ui_nll
travis_time:start:test_ui_nll
Check compiletest suite=ui mode=ui compare_mode=nll (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
[00:48:15] ...........................................................................i........................
[00:48:20] ....................................................................................................
[00:48:25] ....................................................................................................
[00:48:31] ....................................................................................................
[00:48:35] ........i.................iiiiiiiii...................................................
[00:48:35] [00:48:35] finished in 72.973
[00:48:35] travis_fold:end:test_ui_nll
---
[01:27:54] travis_fold:end:stage0-linkchecker
[01:27:54] travis_time:end:stage0-linkchecker:start=1527975360216938164,finish=1527975363078293968,duration=2861355804
[01:27:59] std/collections/struct.HashMap.html:448: broken link fragment `#method.into_mut` pointing to `std/collections/struct.HashMap.html`
[01:27:59] std/collections/struct.BTreeMap.html:158: broken link fragment `#method.into_mut` pointing to `std/collections/struct.BTreeMap.html`
65412 ./src/llvm-emscripten/test/CodeGen
63940 ./obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps
63540 ./obj/build/x86_64-unknown-linux-gnu/stage2-tools
62124 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

frewsxcv · 2018-06-02T22:08:49Z

Fixed the links in the latest force pushes

@bors r=dtolnay

bors · 2018-06-02T22:08:50Z

📌 Commit 4974aab has been approved by dtolnay

rust-highfive · 2018-06-02T23:33:44Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:44:53] ...........................................................................i........................
[00:44:58] ....................................................................................................
[00:45:04] ....................................................................................................
[00:45:10] ....................................................................................................
[00:45:15] ........i.................iiiiiiiii...................................................
[00:45:15] [00:45:15] travis_fold:start:test_ui_nll
travis_time:start:test_ui_nll
Check compiletest suite=ui mode=ui compare_mode=nll (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
[00:46:08] ...........................................................................i........................
[00:46:13] ....................................................................................................
[00:46:18] ....................................................................................................
[00:46:24] ....................................................................................................
[00:46:29] ........i.................iiiiiiiii...................................................
[00:46:29] [00:46:29] finished in 73.648
[00:46:29] travis_fold:end:test_ui_nll
---
[01:23:47] travis_fold:end:stage0-linkchecker
[01:23:47] travis_time:end:stage0-linkchecker:start=1527982400831828395,finish=1527982403512645069,duration=2680816674
[01:23:52] std/collections/struct.BTreeMap.html:158: broken link fragment `#method.into_mut` pointing to `std/collections/struct.BTreeMap.html`

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

frewsxcv · 2018-06-03T00:44:39Z

@bors r=dtolnay

bors · 2018-06-03T00:44:40Z

📌 Commit dd88f88 has been approved by dtolnay

…-mut, r=dtolnay Clarify the difference between get_mut and into_mut for OccupiedEntry The examples for both hash_map::OccupiedEntry::get_mut and hash_map::OccupiedEntry::into_mut were almost identical. This led to some confusion over the difference, namely why you would ever use get_mut when into_mut gives alonger lifetime. Reddit thread: https://www.reddit.com/r/rust/comments/8a5swr/why_does_hashmaps This commit adds two lines and a comment to the example, to show that the entry object can be re-used after calling get_mut. Closesrust-lang#49745

Rollup of 6 pull requests Successful merges: - #51143 (Specify that packed types must derive, not implement, Copy) - #51226 (Make Layout's align a NonZeroUsize) - #51297 (Fix run button style) - #51306 (impl Default for &mut str) - #51312 (Clarify the difference between get_mut and into_mut for OccupiedEntry) - #51313 (use type name in E0599 enum variant suggestion) Failed merges:

Phlosioneer · 2018-06-03T06:19:07Z

Thank you @frewsxcv for finishing this.

Phlosioneer added 2 commits June 2, 2018 15:51

Fixed typo
ed1a8ff

rust-highfive assigned cramertj Jun 2, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2018

frewsxcv mentioned this pull request Jun 2, 2018
Clarify the difference between get_mut and into_mut for OccupiedEntry #49743
Closed

dtolnay approved these changes Jun 2, 2018
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018

Add a couple lines describing differences between into_mut/get_mut.
a86f556

frewsxcv force-pushed the clarify-hash-map-entry-get-mut branch from 5473fb4 to 4974aabCompare June 2, 2018 22:08

Copy changes from HashMap over to BTreeMap.
dd88f88

frewsxcv force-pushed the clarify-hash-map-entry-get-mut branch from 4974aab to dd88f88Compare June 3, 2018 00:44

Mark-Simulacrum mentioned this pull request Jun 3, 2018
Rollup of 6 pull requests #51319
Merged

bors merged commit dd88f88 into rust-lang:masterJun 3, 2018

dtolnay assigned dtolnay and unassigned cramertj Mar 24, 2024

Navigation Menu

Uh oh!

Uh oh!

Clarify the difference between get_mut and into_mut for OccupiedEntry - #51312

Clarify the difference between get_mut and into_mut for OccupiedEntry#51312
bors merged 4 commits into
rust-lang:masterfrom
frewsxcv:clarify-hash-map-entry-get-mut

frewsxcv commented Jun 2, 2018•
edited
Loading

Uh oh!

rust-highfive commented Jun 2, 2018

Uh oh!

frewsxcv commented Jun 2, 2018

Uh oh!

dtolnay left a comment

Uh oh!

dtolnay commented Jun 2, 2018

Uh oh!

bors commented Jun 2, 2018

Uh oh!

rust-highfive commented Jun 2, 2018

Uh oh!

frewsxcv commented Jun 2, 2018

Uh oh!

bors commented Jun 2, 2018

Uh oh!

rust-highfive commented Jun 2, 2018

Uh oh!

frewsxcv commented Jun 3, 2018

Uh oh!

bors commented Jun 3, 2018

Uh oh!

Phlosioneer commented Jun 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

frewsxcv commented Jun 2, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 2, 2018

Uh oh!

frewsxcv commented Jun 2, 2018

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Jun 2, 2018

Uh oh!

bors commented Jun 2, 2018

Uh oh!

rust-highfive commented Jun 2, 2018

Uh oh!

frewsxcv commented Jun 2, 2018

Uh oh!

bors commented Jun 2, 2018

Uh oh!

rust-highfive commented Jun 2, 2018

Uh oh!

frewsxcv commented Jun 3, 2018

Uh oh!

bors commented Jun 3, 2018

Uh oh!

Phlosioneer commented Jun 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

frewsxcv commented Jun 2, 2018•
edited
Loading