suggest `|` when `,` founds in invalid match value by Krout0n · Pull Request #57008 · rust-lang/rust

Krout0n · 2018-12-20T14:06:10Z

Closes#54807
I get stuck on (what | how) I should implement...

rust-highfive · 2018-12-20T14:06:14Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

oli-obk · 2018-12-20T15:26:28Z

You need to update some tests and commit the changes. You can do this via

./x.py test --stage 1 src/test/ui --bless

and adjust the errors at the file:line locations mentioned in the errors until the command passes successfully

petrochenkov · 2018-12-20T23:55:42Z

The current behavior is intentional and has reasons, as it was mentioned in #54807.
In some very popular languages like Python tuples can be written without parentheses (A, B) <=> A, B, so it's reasonable to expect that the user could actually mean (A, B) when writing A, B.

oli-obk · 2018-12-21T09:08:32Z

As I mentioned in #54807 (comment), I believe it would be cool to suggest both(A, B) and A | B. Do you think doing so will complicate the parser more than it's worth it for such a small suggestion?

petrochenkov · 2018-12-21T11:12:18Z

Suggesting both would be ok, the change will need to be done in fn parse_top_level_pat then.
It will give some false positives like recommending let A | B = expr;, but that doesn't matter much, it will become legal soon, at least in the parser.

Krout0n · 2018-12-26T07:48:33Z

Hi, thanks for reviewing! I need solid blocks of time to understand what you mean and implement. So just a moment pls :)

XAMPPRocky · 2019-01-11T13:25:28Z

Triage; @Knium Hello, have you been able to get back to this PR?

Krout0n · 2019-01-13T06:20:06Z

@Aaronepower Hi, thank you for reminding! Sorry, I'm busier than I thought... If this issue has hurry deadline or there is anyone who want to solve, I approve that someone takes my place. If no one else, I'm still eager to challenge this.

TimNN · 2019-01-22T18:46:29Z

Ping from triage @Knium:

Sorry, I'm busier than I thought... If this issue has hurry deadline or there is anyone who want to solve, I approve that someone takes my place.

Don't worry, there is no deadline :). We just like to check in on PRs ~regularly so that we don't have dozens of PRs open that are not being worked on. If you are interested, you can find more information here: https://forge.rust-lang.org/triage-procedure.html

oli-obk

just a nit, then it lgtm

…attern

oli-obk · 2019-01-30T09:01:25Z

@bors r+ rollup

Thanks!

bors · 2019-01-30T09:01:26Z

📌 Commit 62867b4 has been approved by oli-obk

…eses-in-match-with-comma, r=oli-obk suggest `|` when `,` founds in invalid match value Issue rust-lang#54807 I get stuck on (what | how) I should implement...

@ghost

Rollup of 12 pull requests Successful merges: - #57008 (suggest `|` when `,` founds in invalid match value) - #57106 (Mark str::trim.* functions as #[must_use].) - #57920 (use `SOURCE_DATE_EPOCH` for man page time if set) - #57934 (Introduce into_raw_non_null on Rc and Arc) - #57971 (SGX target: improve panic & exit handling) - #57980 (Add the edition guide to the bookshelf) - #57984 (Improve bug message in check_ty) - #57999 (Add MOVBE x86 CPU feature) - #58000 (Fixes and cleanups) - #58005 (update docs for fix_start/end_matches) - #58007 (Don't panic when accessing enum variant ctor using `Self` in match) - #58008 (Pass correct arguments to places_conflict) Failed merges: r? @ghost

rust-highfive assigned petrochenkov Dec 20, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2018

Krout0n changed the title ~~suggest | when , founds in invalid match arms~~suggest | when , founds in invalid match valueDec 20, 2018

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2018

This comment has been minimized.
Sign in to view

Krout0n force-pushed the misleading-try-adding-parentheses-in-match-with-comma branch from 20d7976 to 2a1ee1fCompare January 29, 2019 02:41

This comment has been minimized.
Sign in to view

Krout0n force-pushed the misleading-try-adding-parentheses-in-match-with-comma branch from 2a1ee1f to 1123a65Compare January 29, 2019 04:15

oli-obk requested changes Jan 29, 2019
View reviewed changes

Comment threadsrc/libsyntax/parse/parser.rs Outdated

petrochenkov reviewed Jan 29, 2019
View reviewed changes

Comment threadsrc/libsyntax/parse/parser.rs Outdated

petrochenkov reviewed Jan 29, 2019
View reviewed changes

Comment threadsrc/libsyntax/parse/parser.rs Outdated

Krout0n force-pushed the misleading-try-adding-parentheses-in-match-with-comma branch from 1123a65 to f19935dCompare January 30, 2019 04:49

Suggest to add each of | and () when unexpected , is found in p…
62867b4
…attern

Krout0n force-pushed the misleading-try-adding-parentheses-in-match-with-comma branch from f19935d to 62867b4Compare January 30, 2019 04:51

oli-obk approved these changes Jan 30, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 30, 2019

Centril mentioned this pull request Jan 30, 2019
Rollup of 4 pull requests #57991
Closed

petrochenkov assigned oli-obk and unassigned petrochenkov Jan 30, 2019

Centril mentioned this pull request Jan 30, 2019
Rollup of 6 pull requests #57995
Closed

Centril mentioned this pull request Jan 30, 2019
Rollup of 12 pull requests #58014
Closed

Centril mentioned this pull request Jan 31, 2019
Rollup of 12 pull requests #58016
Merged

bors merged commit 62867b4 into rust-lang:masterJan 31, 2019

Krout0n deleted the misleading-try-adding-parentheses-in-match-with-comma branch January 31, 2019 07:26

goffrie mentioned this pull request Jun 6, 2019
Invalid suggestion to use a vertical bar in let a, b = x;#61573
Closed

Uh oh!

Uh oh!

Conversation

Krout0n commented Dec 20, 2018• edited by Centril Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Dec 20, 2018

Uh oh!

oli-obk commented Dec 20, 2018

Uh oh!

petrochenkov commented Dec 20, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Dec 21, 2018

Uh oh!

petrochenkov commented Dec 21, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krout0n commented Dec 26, 2018

Uh oh!

XAMPPRocky commented Jan 11, 2019

Uh oh!

Krout0n commented Jan 13, 2019

Uh oh!

TimNN commented Jan 22, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Jan 30, 2019

Uh oh!

bors commented Jan 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Krout0n commented Dec 20, 2018•
edited by Centril
Loading

petrochenkov commented Dec 20, 2018•
edited
Loading

petrochenkov commented Dec 21, 2018•
edited
Loading