Skip to content

Introduce into_raw_non_null on Rc and Arc - #57934

Merged
bors merged 1 commit into
rust-lang:masterfrom
dwijnand:from-Arc/Rc-to-NonNull
Jan 31, 2019
Merged

Introduce into_raw_non_null on Rc and Arc#57934
bors merged 1 commit into
rust-lang:masterfrom
dwijnand:from-Arc/Rc-to-NonNull

Conversation

@dwijnand

@dwijnanddwijnand commented Jan 27, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2019
@dwijnanddwijnand mentioned this pull request Jan 27, 2019
Closed
@Centril

Centril commented Jan 27, 2019

Copy link
Copy Markdown
Contributor

r? @alexcrichton

Centril
Centril previously requested changes Jan 27, 2019
View reviewed changes
Comment threadsrc/liballoc/rc.rs Outdated
Comment threadsrc/liballoc/sync.rs Outdated
@Centril
Centril dismissed their stale reviewJanuary 27, 2019 20:06

changes done

@alexcrichton

alexcrichton commented Jan 28, 2019

Copy link
Copy Markdown
Member

Thanks for this! On Box this is called into_raw_non_null, so should the name be updated to match that?

@dwijnand

dwijnand commented Jan 28, 2019

Copy link
Copy Markdown
ContributorAuthor

On Box this is called into_raw_non_null, so should the name be updated to match that?

I assumed the "raw" in Box's version is because it already had an into_raw method, but I wasn't sure if it was appropriate for Arc/Rc. I also don't know if the rename is worth it, but I'm happy to make the old name conform with the new names or make the new names conform with the old name. Do you have a preference?

@alexcrichton

alexcrichton commented Jan 28, 2019

Copy link
Copy Markdown
Member

Nah yeah I think we'll want to prioritize consistency across pointer types, and I think that {Arc,Rc}::into_raw should exist as well!

@dwijnand
dwijnandforce-pushed the from-Arc/Rc-to-NonNull branch from e4edfa4 to f88f4ddCompareJanuary 28, 2019 21:30
@dwijnand

dwijnand commented Jan 28, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

and I think that {Arc,Rc}::into_raw should exist as well!

I'm blind: I'm using{Arc,Rc}::into_raw in the implementation of into_raw_non_null 🙄🙈...

All done!

@dwijnand
dwijnandforce-pushed the from-Arc/Rc-to-NonNull branch from f88f4dd to d968af9CompareJanuary 28, 2019 21:32
@alexcrichton

alexcrichton commented Jan 28, 2019

Copy link
Copy Markdown
Member

As one final nit, could the tracking issue be pointed to the same one as for Box?

@dwijnand
dwijnandforce-pushed the from-Arc/Rc-to-NonNull branch from d968af9 to 5b76913CompareJanuary 28, 2019 22:24
@dwijnand

dwijnand commented Jan 28, 2019

Copy link
Copy Markdown
ContributorAuthor

Sure!

@dwijnand
dwijnandforce-pushed the from-Arc/Rc-to-NonNull branch from 5b76913 to 1e57726CompareJanuary 28, 2019 22:24
@dwijnanddwijnand changed the title Introduce into_non_null on Rc and ArcIntroduce into_raw_non_null on Rc and ArcJan 28, 2019
@alexcrichton

alexcrichton commented Jan 28, 2019

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1e57726 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2019
@Centril

Centril commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
@Centril
Rollup merge ofrust-lang#57934- dwijnand:from-Arc/Rc-to-NonNull, r=…
89f74ac
…alexcrichton
Introduce into_raw_non_null on Rc and Arc
None
@CentrilCentril mentioned this pull request Jan 30, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
@Centril
Rollup merge ofrust-lang#57934- dwijnand:from-Arc/Rc-to-NonNull, r=…
e9de86c
…alexcrichton
Introduce into_raw_non_null on Rc and Arc
None
@CentrilCentril mentioned this pull request Jan 30, 2019
Closed
@CentrilCentril mentioned this pull request Jan 30, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
@Centril
Rollup merge ofrust-lang#57934- dwijnand:from-Arc/Rc-to-NonNull, r=…
f255361
…alexcrichton
Introduce into_raw_non_null on Rc and Arc
None
Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
@Centril
Rollup merge ofrust-lang#57934- dwijnand:from-Arc/Rc-to-NonNull, r=…
1c45d1e
…alexcrichton
Introduce into_raw_non_null on Rc and Arc
None
@CentrilCentril mentioned this pull request Jan 30, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 31, 2019
@Centril
Rollup merge ofrust-lang#57934- dwijnand:from-Arc/Rc-to-NonNull, r=…
e8173a6
…alexcrichton
Introduce into_raw_non_null on Rc and Arc
None
@CentrilCentril mentioned this pull request Jan 31, 2019
Merged
bors added a commit that referenced this pull request Jan 31, 2019
@bors
Auto merge of#58016- Centril:rollup, r=Centril
f40aaa6
Rollup of 12 pull requests
Successful merges:
- #57008 (suggest `|` when `,` founds in invalid match value)
- #57106 (Mark str::trim.* functions as #[must_use].)
- #57920 (use `SOURCE_DATE_EPOCH` for man page time if set)
- #57934 (Introduce into_raw_non_null on Rc and Arc)
- #57971 (SGX target: improve panic & exit handling)
- #57980 (Add the edition guide to the bookshelf)
- #57984 (Improve bug message in check_ty)
- #57999 (Add MOVBE x86 CPU feature)
- #58000 (Fixes and cleanups)
- #58005 (update docs for fix_start/end_matches)
- #58007 (Don't panic when accessing enum variant ctor using `Self` in match)
- #58008 (Pass correct arguments to places_conflict)
Failed merges:
r? @ghost
@bors
bors merged commit 1e57726 into rust-lang:masterJan 31, 2019
@dwijnand
dwijnand deleted the from-Arc/Rc-to-NonNull branch January 31, 2019 07:15
@SimonSapinSimonSapin mentioned this pull request Apr 15, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dwijnand@rust-highfive@Centril@alexcrichton@bors@bluss