Uh oh!
There was an error while loading. Please reload this page.
Add the edition guide to the bookshelf - #57980
Conversation
rust-highfive
commented
Jan 29, 2019
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
QuietMisdreavus
left a comment
There was a problem hiding this comment.
Oh wow, i didn't even realize we were hosting this but didn't have it in the bookshelf listing! Thanks for adding the link!
QuietMisdreavus
commented
Jan 29, 2019
r=me when travis is green. (It's probably not necessary to wait, but i do this out of habit. |
sdht0
commented
Jan 29, 2019
Ah, bookshelf. I edited the title accordingly. |
Centril
commented
Jan 30, 2019
@bors r=QuietMisdreavus rollup |
bors
commented
Jan 30, 2019
📌 Commit 84a89aa has been approved by |
…reavus Add the edition guide to the bookshelf
…reavus Add the edition guide to the bookshelf
…reavus Add the edition guide to the bookshelf
Rollup of 12 pull requests Successful merges: - #57008 (suggest `|` when `,` founds in invalid match value) - #57106 (Mark str::trim.* functions as #[must_use].) - #57920 (use `SOURCE_DATE_EPOCH` for man page time if set) - #57934 (Introduce into_raw_non_null on Rc and Arc) - #57971 (SGX target: improve panic & exit handling) - #57980 (Add the edition guide to the bookshelf) - #57984 (Improve bug message in check_ty) - #57999 (Add MOVBE x86 CPU feature) - #58000 (Fixes and cleanups) - #58005 (update docs for fix_start/end_matches) - #58007 (Don't panic when accessing enum variant ctor using `Self` in match) - #58008 (Pass correct arguments to places_conflict) Failed merges: r? @ghost
No description provided.