Skip to content

add typo suggestion to unknown attribute error - #57904

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:attribute-typos
Jan 29, 2019
Merged

add typo suggestion to unknown attribute error#57904
bors merged 1 commit into
rust-lang:masterfrom
euclio:attribute-typos

Conversation

@euclio

Copy link
Copy Markdown
Contributor

Provides a suggestion using Levenshtein distance to suggest built-in attributes and attribute macros.

Fixes#49270.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2019
Comment threadsrc/librustc_resolve/macros.rs Outdated
Comment threadsrc/test/ui/suggestions/attribute-typos-stable.rs Outdated
Comment threadsrc/librustc_resolve/macros.rs Outdated
@davidtwco

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 5e67021 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 28, 2019
add typo suggestion to unknown attribute error
Provides a suggestion using Levenshtein distance to suggest built-in attributes and attribute macros.
Fixesrust-lang#49270.
@CentrilCentril mentioned this pull request Jan 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 28, 2019
add typo suggestion to unknown attribute error
Provides a suggestion using Levenshtein distance to suggest built-in attributes and attribute macros.
Fixesrust-lang#49270.
@CentrilCentril mentioned this pull request Jan 28, 2019
bors added a commit that referenced this pull request Jan 29, 2019
Rollup of 7 pull requests
Successful merges:
- #57045 (Kill remaining uses of mem::uninitialized in libcore, liballoc)
- #57674 (Avoid erase_regions_ty queries if there are no regions to erase)
- #57833 (Print a slightly clearer message when failing to launch a thread)
- #57859 (Fix invalid background color)
- #57904 (add typo suggestion to unknown attribute error)
- #57915 (Pretty print `$crate` as `crate` or `crate_name` in more cases)
- #57950 (Extend E0106, E0261)
Failed merges:
r? @ghost
@bors
bors merged commit 5e67021 into rust-lang:masterJan 29, 2019
@euclio
euclio deleted the attribute-typos branch January 29, 2019 13:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@euclio@rust-highfive@davidtwco@bors@Centril@estebank@VirrageS