Uh oh!
There was an error while loading. Please reload this page.
Pretty print $crate as crate or crate_name in more cases - #57915
Merged
Conversation
rust-highfive
commented
Jan 26, 2019
Contributor
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced Jan 26, 2019
petrochenkov
commented
Jan 28, 2019
ContributorAuthor
r? @dtolnay |
zackmdavis
commented
Jan 28, 2019
Contributor
@petrochenkov Very sorry for the delay! LGTM r? @zackmdavis @bors r+ |
bors
commented
Jan 28, 2019
Collaborator
📌 Commit c375333 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jan 28, 2019
Pretty print `$crate` as `crate` or `crate_name` in more cases So, people do parse output of `--pretty=expanded` (sigh), so covering only the legacy proc-macro case (like it was done in rust-lang#57155) is not enough. This PRs resolves all `$crate`s produced by macros, so they are all printed in the parseable form `$crate::foo` -> `crate::foo` or `crate_name::foo`. Fixesrust-lang#38016 (comment)Fixesrust-lang#57155 (comment)
Centril added a commit
to Centril/rust
that referenced
this pull request
Jan 28, 2019
Pretty print `$crate` as `crate` or `crate_name` in more cases So, people do parse output of `--pretty=expanded` (sigh), so covering only the legacy proc-macro case (like it was done in rust-lang#57155) is not enough. This PRs resolves all `$crate`s produced by macros, so they are all printed in the parseable form `$crate::foo` -> `crate::foo` or `crate_name::foo`. Fixesrust-lang#38016 (comment)Fixesrust-lang#57155 (comment)
bors added a commit
that referenced
this pull request
Jan 29, 2019
Rollup of 7 pull requests Successful merges: - #57045 (Kill remaining uses of mem::uninitialized in libcore, liballoc) - #57674 (Avoid erase_regions_ty queries if there are no regions to erase) - #57833 (Print a slightly clearer message when failing to launch a thread) - #57859 (Fix invalid background color) - #57904 (add typo suggestion to unknown attribute error) - #57915 (Pretty print `$crate` as `crate` or `crate_name` in more cases) - #57950 (Extend E0106, E0261) Failed merges: r? @ghost
borsBot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Mar 1, 2019
84: Create buffer mapped r=kvark a=swiftcoder I haven't really taken a swing at error handling here, posting it up early for feedback on the API. 85: Unpin nightly date for bindings generation r=kvark a=grovesNL rust-lang/rust#57915 allows us to run bindings generation with nightly again, so we shouldn't have to pin to an older nightly date anymore (assuming everyone has a recent nightly). Co-authored-by: Tristam MacDonald <tristam@trist.am> Co-authored-by: Joshua Groves <josh@joshgroves.com>
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 10, 2019
…ulacrum Fix pretty-printing of `$crate` (take 4) Pretty-print `$crate` as `crate` or `crate_name` in unstructured tokens like `a $crate c` in `foo!(a $crate c)`, but only if those tokens are printed as a part of AST pretty-printing, rather than as a standalone token stream. Fixesrust-lang#62325 Previous iterations - rust-lang#56647, rust-lang#57155, rust-lang#57915.
kvark pushed a commit
to gfx-rs/wgpu-native
that referenced
this pull request
Apr 17, 2020
84: Create buffer mapped r=kvark a=swiftcoder I haven't really taken a swing at error handling here, posting it up early for feedback on the API. 85: Unpin nightly date for bindings generation r=kvark a=grovesNL rust-lang/rust#57915 allows us to run bindings generation with nightly again, so we shouldn't have to pin to an older nightly date anymore (assuming everyone has a recent nightly). Co-authored-by: Tristam MacDonald <tristam@trist.am> Co-authored-by: Joshua Groves <josh@joshgroves.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, people do parse output of
--pretty=expanded(sigh), so covering only the legacy proc-macro case (like it was done in #57155) is not enough.This PRs resolves all
$crates produced by macros, so they are all printed in the parseable form$crate::foo->crate::fooorcrate_name::foo.Fixes#38016 (comment)
Fixes#57155 (comment)