Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #57955
Closed
Centril wants to merge 10 commits into
Closed
Conversation
Currently, the target of a use statement will be updated with the visibility of the use statement itself (if the use statement was visible). This commit ensures that if the path to the target item is via another use statement then that intermediate use statement will also have the visibility updated like the target. This silences incorrect `unreachable_pub` lints with inactionable suggestions.
…alexcrichton Print a slightly clearer message when failing to launch a thread As discussed in rust-lang#46345, the `io::Error` you get when a thread fails to launch is of type `io::ErrorKind::WouldBlock`. This is super uninformative when an arbitrary `thread::spawn` fails somewhere in your code: ``` thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 11, kind: WouldBlock, message: "operation would block" }', src/libcore/result.rs:997:5 ``` This PR improves the situation a little bit by using `expect` instead of `unwrap`. I don't consider this a complete fix for rust-lang#46345 though.
…ietMisdreavus Fix invalid background color As discussed in rust-lang#57814. r? @QuietMisdreavus
add typo suggestion to unknown attribute error Provides a suggestion using Levenshtein distance to suggest built-in attributes and attribute macros. Fixesrust-lang#49270.
Pretty print `$crate` as `crate` or `crate_name` in more cases So, people do parse output of `--pretty=expanded` (sigh), so covering only the legacy proc-macro case (like it was done in rust-lang#57155) is not enough. This PRs resolves all `$crate`s produced by macros, so they are all printed in the parseable form `$crate::foo` -> `crate::foo` or `crate_name::foo`. Fixesrust-lang#38016 (comment)Fixesrust-lang#57155 (comment)
Update visibility of intermediate use items. Fixesrust-lang#57410 and fixesrust-lang#53925 and fixesrust-lang#47816. Currently, the target of a use statement will be updated with the visibility of the use statement itself (if the use statement was visible). This PR ensures that if the path to the target item is via another use statement then that intermediate use statement will also have the visibility updated like the target. This silences incorrect `unreachable_pub` lints with inactionable suggestions.
Centril
commented
Jan 28, 2019
ContributorAuthor
@bors r+ p=5 |
bors
commented
Jan 28, 2019
Collaborator
📌 Commit ae34f21 has been approved by |
bors
commented
Jan 28, 2019
Collaborator
⌛ Testing commit ae34f21 with merge 8fad8648496acb2dba01d9ee7a21b1eee67005ba... |
bors
commented
Jan 28, 2019
Collaborator
💔 Test failed - status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
$crateascrateorcrate_namein more cases #57915 (Pretty print$crateascrateorcrate_namein more cases)Failed merges:
r? @ghost