Uh oh!
There was an error while loading. Please reload this page.
Refactor InferenceFudger (née RegionFudger) - #59415
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
eddyb
left a comment
There was a problem hiding this comment.
r=me with comments addressed (or wait for @nikomatsakis' review)
Uh oh!
There was an error while loading. Please reload this page.
eddyb
commented
Mar 26, 2019
@bors r+ |
bors
commented
Mar 26, 2019
📌 Commit 2b4171bb967bb709326a4255f4dc06f70addae0b has been approved by |
varkor
commented
Mar 26, 2019
bors
commented
Mar 27, 2019
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
2b4171b to
86d5a69Comparevarkor
commented
Mar 27, 2019
@bors r=eddyb |
bors
commented
Mar 27, 2019
📌 Commit 86d5a69 has been approved by |
bors
commented
Mar 27, 2019
Refactor InferenceFudger (née RegionFudger) - Rename `RegionFudger` (and related methods) to `InferenceFudger`. - Take integer and float inference variables into account. - Refactor `types_created_since_snapshot` and `vars_created_since_snapshot` with the [new version of ena](rust-lang/ena#21). - Some other refactoring in the area. r? @eddyb
bors
commented
Mar 27, 2019
☀️ Test successful - checks-travis, status-appveyor |
RegionFudger(and related methods) toInferenceFudger.types_created_since_snapshotandvars_created_since_snapshotwith the new version of ena.r? @eddyb