Skip to content

Add tests for concrete const types - #60550

Merged
bors merged 1 commit into
rust-lang:masterfrom
BenLewis-Seequent:concrete_const_tests
May 9, 2019
Merged

Add tests for concrete const types#60550
bors merged 1 commit into
rust-lang:masterfrom
BenLewis-Seequent:concrete_const_tests

Conversation

@BenLewis-Seequent

@BenLewis-SeequentBenLewis-Seequent commented May 4, 2019

Copy link
Copy Markdown

In response to the request for help in #44580 (comment), I have added several ui tests around the use of concrete const types, i.e. A<2>.

r? @varkor

@rust-highfive

rust-highfive commented May 4, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2019
Centril
Centril suggested changes May 5, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; but "static method" is not a concept we use anymore.

Comment threadsrc/test/ui/const-generics/concrete-const-impl-static-method.rs Outdated
varkor
varkor reviewed May 6, 2019
View reviewed changes
Comment threadsrc/test/ui/const-generics/concrete-const-impl-associated-non-method.rs Outdated
@varkor

varkor commented May 6, 2019

Copy link
Copy Markdown
Contributor

Looks good, thanks! If you could merge the concrete-const-impl-associated-non-method.rs and concrete-const-impl-method.rs tests and squash the commits into one, I'll approve.

@varkorvarkor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2019
@varkor

varkor commented May 8, 2019

Copy link
Copy Markdown
Contributor

@Skinny121: thank you very much!

@bors r+ rollup

@bors

bors commented May 8, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit bfa15f3 has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 8, 2019
Centril added a commit to Centril/rust that referenced this pull request May 8, 2019
@Centril
Rollup merge ofrust-lang#60550- skinny121:concrete_const_tests, r=v…
59ff113
…arkor
Add tests for concrete const types
In response to the request for help in rust-lang#44580 (comment), I have added several ui tests around the use of concrete const types, i.e. A<2>.
r? @varkor
@CentrilCentril mentioned this pull request May 8, 2019
Merged
bors added a commit that referenced this pull request May 8, 2019
@bors
Auto merge of#60651- Centril:rollup-zoamjfk, r=Centril
9f83961
Rollup of 8 pull requests
Successful merges:
- #59979 (to_xe_bytes for isize and usize returns an array of different size)
- #60491 (std: Update compiler-builtins crate)
- #60550 (Add tests for concrete const types)
- #60572 (Add test for #59972)
- #60627 (test for #50518)
- #60634 (Document + Cleanup lang_items.rs)
- #60641 (Instead of ICEing on incorrect pattern, use delay_span_bug)
- #60644 (Use `delay_span_bug` for "Failed to unify obligation")
Failed merges:
r? @ghost
@bors
bors merged commit bfa15f3 into rust-lang:masterMay 9, 2019
@varkorvarkor added the F-const_generics `#![feature(const_generics)]` label Oct 19, 2019
@varkorvarkor mentioned this pull request Oct 19, 2019
Closed
16 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@varkorvarkorvarkor left review comments
@CentrilCentrilCentril requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@varkorvarkor

Labels

F-const_generics`#![feature(const_generics)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BenLewis-Seequent@rust-highfive@varkor@bors@Centril@skinnyBat