Uh oh!
There was an error while loading. Please reload this page.
test for #50518 - #60627
Merged
Merged
Conversation
Centril
commented
May 8, 2019
Contributor
Move this to |
It was fixed somewhere between 1.28.0 and 1.31.1 closesrust-lang#50518
matklad
commented
May 8, 2019
ContributorAuthor
Thanks, @Centril ! |
estebank
commented
May 8, 2019
Contributor
@bors r+ rollup |
bors
commented
May 8, 2019
Collaborator
📌 Commit c87d2cc has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
May 8, 2019
test for rust-lang#50518 It was fixed somewhere between 1.28.0 and 1.31.1 closesrust-lang#50518 r? @estebank Where's the best place to add this test? I *think* we want "compile-pass" for this test (no need to run a binary, and not running saves us a millisecond of process creation) , but there's no compile-pass anymore. Should this be UI test with empty stdout, stderr and zero return code?
Centril added a commit
to Centril/rust
that referenced
this pull request
May 8, 2019
test for rust-lang#50518 It was fixed somewhere between 1.28.0 and 1.31.1 closesrust-lang#50518 r? @estebank Where's the best place to add this test? I *think* we want "compile-pass" for this test (no need to run a binary, and not running saves us a millisecond of process creation) , but there's no compile-pass anymore. Should this be UI test with empty stdout, stderr and zero return code?
Centril added a commit
to Centril/rust
that referenced
this pull request
May 8, 2019
test for rust-lang#50518 It was fixed somewhere between 1.28.0 and 1.31.1 closesrust-lang#50518 r? @estebank Where's the best place to add this test? I *think* we want "compile-pass" for this test (no need to run a binary, and not running saves us a millisecond of process creation) , but there's no compile-pass anymore. Should this be UI test with empty stdout, stderr and zero return code?
bors added a commit
that referenced
this pull request
May 8, 2019
Rollup of 8 pull requests Successful merges: - #59979 (to_xe_bytes for isize and usize returns an array of different size) - #60491 (std: Update compiler-builtins crate) - #60550 (Add tests for concrete const types) - #60572 (Add test for #59972) - #60627 (test for #50518) - #60634 (Document + Cleanup lang_items.rs) - #60641 (Instead of ICEing on incorrect pattern, use delay_span_bug) - #60644 (Use `delay_span_bug` for "Failed to unify obligation") Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was fixed somewhere between 1.28.0 and 1.31.1
closes#50518
r? @estebank
Where's the best place to add this test? I think we want "compile-pass" for this test (no need to run a binary, and not running saves us a millisecond of process creation) , but there's no compile-pass anymore.
Should this be UI test with empty stdout, stderr and zero return code?