Skip to content

Instead of ICEing on incorrect pattern, use delay_span_bug - #60641

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:defer-ice
May 9, 2019
Merged

Instead of ICEing on incorrect pattern, use delay_span_bug#60641
bors merged 1 commit into
rust-lang:masterfrom
estebank:defer-ice

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix#60635.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2019
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 8, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit cc40f41 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2019
Centril added a commit to Centril/rust that referenced this pull request May 8, 2019
Instead of ICEing on incorrect pattern, use delay_span_bug
Fixrust-lang#60635.
@CentrilCentril mentioned this pull request May 8, 2019
bors added a commit that referenced this pull request May 8, 2019
Rollup of 8 pull requests
Successful merges:
- #59979 (to_xe_bytes for isize and usize returns an array of different size)
- #60491 (std: Update compiler-builtins crate)
- #60550 (Add tests for concrete const types)
- #60572 (Add test for #59972)
- #60627 (test for #50518)
- #60634 (Document + Cleanup lang_items.rs)
- #60641 (Instead of ICEing on incorrect pattern, use delay_span_bug)
- #60644 (Use `delay_span_bug` for "Failed to unify obligation")
Failed merges:
r? @ghost
@bors
bors merged commit cc40f41 into rust-lang:masterMay 9, 2019
@bors

bors commented May 9, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cc40f41 with merge 9f83961...

@estebankestebank added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 9, 2019
@pnkfelix

Copy link
Copy Markdown
Contributor

discussed at T-compiler meeting. accepted for beta-backport.

@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 16, 2019
@emilyalbiniemilyalbini mentioned this pull request May 17, 2019
@emilyalbiniemilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 17, 2019
bors added a commit that referenced this pull request May 18, 2019
[beta] Rollup backports
Rolled up:
* [beta] save-analysis: Pull associated type definition using `qpath_def` #60881
* [beta] Update clippy #60918
Cherry-picked:
* Instead of ICEing on incorrect pattern, use delay_span_bug #60641
* Use `delay_span_bug` for "Failed to unify obligation" #60644
r? @ghost
@estebank
estebank deleted the defer-ice branch November 9, 2023 05:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE on tuple struct pattern

6 participants

@estebank@rust-highfive@oli-obk@bors@pnkfelix@emilyalbini