typeck: prohibit foreign statics w/ generics by davidtwco · Pull Request #65133 · rust-lang/rust

davidtwco · 2019-10-05T16:15:40Z

This PR modifies resolve to disallow foreign statics that have
generics.

improper_ctypes is not written to support type parameters, as these
are normally disallowed before the lint is run. Thus, type parameters in
foreign statics must be prohibited before the lint.

The only other case where this could have occured is in functions,
but typeck prohibits this with a "foreign items may not have type
parameters" error - a similar error did not exist for statics, because
statics cannot have type parameters, but they can use any
type parameters that are in scope (which isn't the case for functions).

rust-highfive · 2019-10-05T16:15:43Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-10-06T21:41:34Z

statics cannot have type parameters, but they can use any
type parameters that are in scope (which isn't the case for functions).

Odd... ISTM that static should not be able to reference type parameter from an other scope either and that the failure should happen in resolve.

cc @petrochenkov

petrochenkov · 2019-10-06T21:56:55Z

Yeah, this should be prevented by some barrier in resolve like ItemRibKind or something, at least for type parameters.

davidtwco · 2019-10-06T21:59:40Z

Yeah, this should be prevented by some barrier in resolve like ItemRibKind or something, at least for type parameters.

I'll modify this PR to prohibit this in resolve instead.

Centril · 2019-10-06T21:59:59Z

r? @petrochenkov

davidtwco · 2019-10-08T12:05:59Z

@petrochenkov I've re-worked this PR to fix this in resolve instead.

I've introduced a StaticItemRibKind but that was only so I could avoid the misleading diagnostic, the actual prohibition of generics from foreign statics worked with just an ItemRibKind, so if you have a alternative approach to improving that diagnostic, I'm happy to do that.

(cc @varkor, this also resolves your comment about const params)

petrochenkov · 2019-10-08T15:59:18Z

I've introduced a StaticItemRibKind but that was only so I could avoid the misleading diagnostic

I'd rather add a flag for this to ItemRibKind.

(FnItemRibKind is also very weird, all this stuff needs an audit (and the whole idea of conflating scopes with barriers is questionable), but that's for a different PR, I guess.)

davidtwco · 2019-10-08T16:34:45Z

I'd rather add a flag for this to ItemRibKind.

@petrochenkov I've updated the PR to add a flag to ItemRibKind instead of StaticItemRibKind.

This commit modifies resolve to disallow foreign statics that use parent generics. `improper_ctypes` is not written to support type parameters, as these are normally disallowed before the lint is run. Thus, type parameters in foreign statics must be prohibited before the lint. The only other case where this *could* have occured is in functions, but typeck prohibits this with a "foreign items may not have type parameters" error - a similar error did not exist for statics, because statics cannot have type parameters, but they can use any type parameters that are in scope (which isn't the case for functions). Signed-off-by: David Wood <david@davidtw.co>

petrochenkov · 2019-10-08T17:55:01Z

Thanks!
@bors r+

bors · 2019-10-08T17:55:02Z

📌 Commit ccbf2b7 has been approved by petrochenkov

…eneric-in-foreign-mod, r=petrochenkov typeck: prohibit foreign statics w/ generics Fixesrust-lang#65035 and fixesrust-lang#65025. This PR modifies resolve to disallow foreign statics that have generics. `improper_ctypes` is not written to support type parameters, as these are normally disallowed before the lint is run. Thus, type parameters in foreign statics must be prohibited before the lint. The only other case where this *could* have occured is in functions, but typeck prohibits this with a "foreign items may not have type parameters" error - a similar error did not exist for statics, because statics cannot have type parameters, but they can use any type parameters that are in scope (which isn't the case for functions).

@ghost

Rollup of 7 pull requests Successful merges: - #64284 (Warn if include macro fails to include entire file) - #65081 (Remove -Zprofile-queries) - #65133 (typeck: prohibit foreign statics w/ generics) - #65135 (Add check for missing tests for error codes) - #65141 (Replace code of conduct with link) - #65194 (Use structured suggestion for removal of `as_str()` call) - #65213 (Ignore `ExprKind::DropTemps` for some ref suggestions) Failed merges: r? @ghost

rust-highfive assigned cramertj Oct 5, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2019

Centril reviewed Oct 6, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated

rust-highfive assigned petrochenkov and unassigned cramertj Oct 6, 2019

davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2019

davidtwco mentioned this pull request Oct 6, 2019
type parameter A/#0 (A/0) out of range when substituting (root type=Some(*const A)) substs=[] #65025
Closed

davidtwco force-pushed the issue-65035-static-with-generic-in-foreign-mod branch from bf1e55c to 1f7a051Compare October 8, 2019 12:03

davidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2019

petrochenkov reviewed Oct 8, 2019
View reviewed changes

Comment threadsrc/librustc_resolve/late.rs Outdated

davidtwco force-pushed the issue-65035-static-with-generic-in-foreign-mod branch from 1f7a051 to b514344Compare October 8, 2019 16:33

Centril reviewed Oct 8, 2019
View reviewed changes

Comment threadsrc/librustc_resolve/late.rs Outdated
Comment threadsrc/librustc_resolve/late.rs Outdated
Comment threadsrc/librustc_resolve/late.rs Outdated

petrochenkov reviewed Oct 8, 2019
View reviewed changes

Comment threadsrc/librustc_resolve/late.rs Outdated

davidtwco force-pushed the issue-65035-static-with-generic-in-foreign-mod branch from b514344 to 5a46a09Compare October 8, 2019 17:32

davidtwco force-pushed the issue-65035-static-with-generic-in-foreign-mod branch from 5a46a09 to ccbf2b7Compare October 8, 2019 17:51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2019

Centril mentioned this pull request Oct 8, 2019
Rollup of 7 pull requests #65223
Merged

bors merged commit ccbf2b7 into rust-lang:masterOct 9, 2019

davidtwco deleted the issue-65035-static-with-generic-in-foreign-mod branch October 11, 2019 14:18

Uh oh!

Uh oh!

Conversation

davidtwco commented Oct 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Oct 5, 2019

Uh oh!

Uh oh!

Uh oh!

Centril commented Oct 6, 2019

Uh oh!

petrochenkov commented Oct 6, 2019

Uh oh!

davidtwco commented Oct 6, 2019

Uh oh!

Centril commented Oct 6, 2019

Uh oh!

davidtwco commented Oct 8, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Oct 8, 2019

Uh oh!

Uh oh!

davidtwco commented Oct 8, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Oct 8, 2019

Uh oh!

bors commented Oct 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

davidtwco commented Oct 5, 2019•
edited
Loading

davidtwco commented Oct 8, 2019•
edited
Loading