Uh oh!
There was an error while loading. Please reload this page.
Ignore ExprKind::DropTemps for some ref suggestions - #65213
Merged
Conversation
rust-highfive
commented
Oct 8, 2019
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
estebank
commented
Oct 8, 2019
ContributorAuthor
r? @Centril |
Centril
reviewed
Oct 8, 2019
Centril
left a comment
Contributor
There was a problem hiding this comment.
r=me with peel_drop_temps redefined as below.
Uh oh!
There was an error while loading. Please reload this page.
Centril
reviewed
Oct 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
Centril
reviewed
Oct 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Oct 8, 2019
Contributor
r=me when... |
estebank
commented
Oct 8, 2019
ContributorAuthor
@bors r=Centril |
bors
commented
Oct 8, 2019
Collaborator
📌 Commit d0eea6f has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 8, 2019
Ignore `ExprKind::DropTemps` for some ref suggestions Introduce `Expr::peel_drop_temps()` to ignore `ExprKind::DropTemps` for suggestions that depend on the `ExprKind` for accuracy.
bors added a commit
that referenced
this pull request
Oct 8, 2019
Rollup of 7 pull requests Successful merges: - #64284 (Warn if include macro fails to include entire file) - #65081 (Remove -Zprofile-queries) - #65133 (typeck: prohibit foreign statics w/ generics) - #65135 (Add check for missing tests for error codes) - #65141 (Replace code of conduct with link) - #65194 (Use structured suggestion for removal of `as_str()` call) - #65213 (Ignore `ExprKind::DropTemps` for some ref suggestions) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
Expr::peel_drop_temps()to ignoreExprKind::DropTempsfor suggestions that depend on theExprKindfor accuracy.