Uh oh!
There was an error while loading. Please reload this page.
remove non-sysroot sources from rust-src component - #69631
Conversation
rust-highfive
commented
Mar 2, 2020
(rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Mar 2, 2020
Keep in mind that since then, When I wrote "Everything else makes sense." I probably imagined we could have most of |
RalfJung
commented
Mar 2, 2020
Yeah, having just the sources of these two crates without all their dependencies seems pretty useless. Hence this PR. |
Mark-Simulacrum
commented
Mar 4, 2020
I am in favor of removing these, particularly as I believe it's highly likely that they're not doing too much good since we've stripped so much out of them these days into other crates. I think the best way to do so would be to land this change now-ish and then if people complain evaluate readding them (perhaps into the rustc-dev component?). I doubt that people are aware that they are using them if they are. cc @matklad as well, in case IntelliJ or other IDE tooling wants these for some reason. |
matklad
commented
Mar 5, 2020
No, neither IntelliJ nor rust-analyzer needs |
Mark-Simulacrum
commented
Mar 5, 2020
I'm going to approve this in that case. If someone feels we should get wider consensus, though, please feel free to unapprove. @bors r+ |
bors
commented
Mar 5, 2020
📌 Commit cbf52b1 has been approved by |
RalfJung
commented
Mar 6, 2020
@bors rollup |
remove non-sysroot sources from rust-src component See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources. OTOH, @eddyb [wrote](rust-lang#58269 (comment)) > Yeah, my question is why librustc_plugin specifically? Everything else makes sense. So maybe there is some good reason to keep these? Then we should have a comment explaining that reason. Cc @eddyb@taeguk@Mark-Simulacrum
Rollup of 8 pull requests Successful merges: - #69631 (remove non-sysroot sources from rust-src component) - #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests)) - #69651 (Try to ensure usize marker does not get merged) - #69668 (More documentation and simplification of BTreeMap's internals) - #69685 (unix: Don't override existing SIGSEGV/BUS handlers) - #69771 (Cleanup E0390 explanation) - #69777 (Add missing ` in doc for File::with_options()) - #69812 (Refactorings to method/probe.rs and CrateId) Failed merges: r? @ghost
Rollup of 7 pull requests Successful merges: - #69631 (remove non-sysroot sources from rust-src component) - #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests)) - #69651 (Try to ensure usize marker does not get merged) - #69668 (More documentation and simplification of BTreeMap's internals) - #69771 (Cleanup E0390 explanation) - #69777 (Add missing ` in doc for File::with_options()) - #69812 (Refactorings to method/probe.rs and CrateId) Failed merges: r? @ghost
See #69592 (comment): these were likely added in #58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources.
OTOH, @eddybwrote
So maybe there is some good reason to keep these? Then we should have a comment explaining that reason.
Cc @eddyb@taeguk@Mark-Simulacrum