Skip to content

More documentation and simplification of BTreeMap's internals - #69668

Merged
bors merged 1 commit into
rust-lang:masterfrom
ssomers:btreemap_even_more_comments
Mar 8, 2020
Merged

More documentation and simplification of BTreeMap's internals#69668
bors merged 1 commit into
rust-lang:masterfrom
ssomers:btreemap_even_more_comments

Conversation

@ssomers

Copy link
Copy Markdown
Contributor

Salvage the documentation and simplification from #67980, without changing the type locked down by debuginfo.

r? @rkruppe

Comment threadsrc/liballoc/collections/btree/node.rs Outdated
@JohnTitor

Copy link
Copy Markdown
Member

I believe you mean r? @hanna-kruppe

@JohnTitorJohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2020
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 9384cba has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
…, r=Mark-Simulacrum
More documentation and simplification of BTreeMap's internals
Salvage the documentation and simplification from rust-lang#67980, without changing the type locked down by debuginfo.
r? @rkruppe
@CentrilCentril mentioned this pull request Mar 8, 2020
bors added a commit that referenced this pull request Mar 8, 2020
Rollup of 8 pull requests
Successful merges:
- #69631 (remove non-sysroot sources from rust-src component)
- #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests))
- #69651 (Try to ensure usize marker does not get merged)
- #69668 (More documentation and simplification of BTreeMap's internals)
- #69685 (unix: Don't override existing SIGSEGV/BUS handlers)
- #69771 (Cleanup E0390 explanation)
- #69777 (Add missing ` in doc for File::with_options())
- #69812 (Refactorings to method/probe.rs and CrateId)
Failed merges:
r? @ghost
@CentrilCentril mentioned this pull request Mar 8, 2020
bors added a commit that referenced this pull request Mar 8, 2020
Rollup of 7 pull requests
Successful merges:
- #69631 (remove non-sysroot sources from rust-src component)
- #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests))
- #69651 (Try to ensure usize marker does not get merged)
- #69668 (More documentation and simplification of BTreeMap's internals)
- #69771 (Cleanup E0390 explanation)
- #69777 (Add missing ` in doc for File::with_options())
- #69812 (Refactorings to method/probe.rs and CrateId)
Failed merges:
r? @ghost
@bors
bors merged commit c13d296 into rust-lang:masterMar 8, 2020
@ssomers
ssomers deleted the btreemap_even_more_comments branch March 9, 2020 08:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ssomers@JohnTitor@Mark-Simulacrum@bors@hanna-kruppe