Skip to content

Refactorings to method/probe.rs and CrateId - #69812

Merged
bors merged 2 commits into
rust-lang:masterfrom
Marwes:refactor
Mar 8, 2020
Merged

Refactorings to method/probe.rs and CrateId#69812
bors merged 2 commits into
rust-lang:masterfrom
Marwes:refactor

Conversation

@Marwes

Copy link
Copy Markdown
Contributor

A couple of refactorings done while looking into performance improvements in method resolution.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2020
Comment threadsrc/librustc_span/lib.rs Outdated
Comment threadsrc/librustc_span/lib.rs Outdated
Comment threadsrc/librustc_span/lib.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2020
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 8, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 6095fa1 has been approved by petrochenkov

@bors

bors commented Mar 8, 2020

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 8, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
Refactorings to method/probe.rs and CrateId
A couple of refactorings done while looking into performance improvements in method resolution.
@CentrilCentril mentioned this pull request Mar 8, 2020
bors added a commit that referenced this pull request Mar 8, 2020
Rollup of 8 pull requests
Successful merges:
- #69631 (remove non-sysroot sources from rust-src component)
- #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests))
- #69651 (Try to ensure usize marker does not get merged)
- #69668 (More documentation and simplification of BTreeMap's internals)
- #69685 (unix: Don't override existing SIGSEGV/BUS handlers)
- #69771 (Cleanup E0390 explanation)
- #69777 (Add missing ` in doc for File::with_options())
- #69812 (Refactorings to method/probe.rs and CrateId)
Failed merges:
r? @ghost
@CentrilCentril mentioned this pull request Mar 8, 2020
bors added a commit that referenced this pull request Mar 8, 2020
Rollup of 7 pull requests
Successful merges:
- #69631 (remove non-sysroot sources from rust-src component)
- #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests))
- #69651 (Try to ensure usize marker does not get merged)
- #69668 (More documentation and simplification of BTreeMap's internals)
- #69771 (Cleanup E0390 explanation)
- #69777 (Add missing ` in doc for File::with_options())
- #69812 (Refactorings to method/probe.rs and CrateId)
Failed merges:
r? @ghost
@bors
bors merged commit 06689e2 into rust-lang:masterMar 8, 2020
@Marwes
Marwes deleted the refactor branch March 9, 2020 10:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Marwes@rust-highfive@petrochenkov@bors